feat: replace binary log driver with FIFO-based in-process logging#441
Draft
ayush-panta wants to merge 4 commits into
Draft
feat: replace binary log driver with FIFO-based in-process logging#441ayush-panta wants to merge 4 commits into
ayush-panta wants to merge 4 commits into
Conversation
ayush-panta
force-pushed
the
feat/fifo-logging
branch
6 times, most recently
from
afd4674 to
0424065
Compare
ayush-panta
force-pushed
the
feat/fifo-logging
branch
from
0424065 to
d7d055b
Compare
ayush-panta
force-pushed
the
feat/fifo-logging
branch
from
d7d055b to
a99004e
Compare
ayush-panta
force-pushed
the
feat/fifo-logging
branch
from
2632a7d to
205d13a
Compare
ayush-panta
force-pushed
the
feat/fifo-logging
branch
from
205d13a to
a99004e
Compare
Signed-off-by: ayush-panta <[email protected]>
Pin the durable functions emulator to v1.1.1 to avoid upstream event ordering regression in the latest image. SAM CLI unpinned this in v1.162.0 (#9054) and their own CI is now failing the same way. Signed-off-by: ayush-panta <[email protected]>
Apply upstream fix from aws/aws-sam-cli#9097 — the emulator now reports WaitForCallback instead of RunInChildContext. This patch can be removed once a new SAM CLI release includes the fix. Signed-off-by: ayush-panta <[email protected]>
ayush-panta
force-pushed
the
feat/fifo-logging
branch
from
c7e797d to
abc62be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: Replace the
binary://log driver with FIFO-based in-process logging. Instead of containerd's shim forking an external binary to capture container stdout/stderr, finch-daemon reads container output directly via named pipes and writes json-file logs itself. This requires us to move away from using nerdctl's container start and implement our own custom start function.This is the first of two PRs to remove finch-daemon's runtime dependency on the nerdctl binary. This PR handles logging; a follow-up PR will handle networking (hookless CNI setup/teardown), also depending on the custom start implementation.
Testing done: Added unit and e2e testing. I also manually performed extensive testing of standard use cases when developing the proof of concept.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.