Skip to content

docs: Create CONTRIBUTING.md#12

Open
vsiravar wants to merge 2 commits into
runfinch:mainfrom
vsiravar:vsiravar/add-contributing-guidelines
Open

docs: Create CONTRIBUTING.md#12
vsiravar wants to merge 2 commits into
runfinch:mainfrom
vsiravar:vsiravar/add-contributing-guidelines

Conversation

@vsiravar

Copy link
Copy Markdown
Contributor

Signed-off-by: Vishwas Siravara [email protected]

Issue #, if available:
2
Description of changes:
Add CONTRIBUTING.md file for contributing guidelines.

Testing done:
N/A

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pendo324 pendo324 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nit comment, LGTM otherwise!

Comment thread CONTRIBUTING.md
## Find an Issue

We have good first issues for new contributors and help wanted issues suitable
for any contributor. [good first issue](TODO) has extra information to

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the "good first issue" and "help wanted" links? Nit: also might want to sentence case them (so like "Good first issue"), just because they're right after a period. I think the casing is probably off in other repos too though so this isn't a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants