feat(mail): show attachment detail tooltips#1985
Open
keilogic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1446.
Summary
Testing
npm cinpx tsc -p src/tsconfig.app.json --noEmitnpx tsc -p src/tsconfig.spec.json --noEmitnpx ng test runbox7 --watch=false --browsers=FirefoxHeadless --include=src/app/mailviewer/singlemailviewer.component.spec.ts(9 success; existing template warnings and mocked attachment thumbnail 404 noise)npx ng test runbox7 --watch=false --browsers=FirefoxHeadless(first run hit a Firefox no-message disconnect after 245 success; rerun passed with 246 success and 2 skipped, with existing template warnings)npm run lint -- --quietgit diff --check origin/master...HEADgit show --check --stat --oneline HEADnpm run policy(current commits OK; historical upstream commit-message warnings still printed)$env:SKIP_CHANGELOG='1'; node src/build/pre-build.js; npx ng build --configuration production --base-href=/app/ runbox7; node src/build/post-build.js(production build hash6494274c6d5a7d0c; existing Angular/Sass/CommonJS warnings)AI Disclosure
I used OpenAI Codex/GPT-5 in a local development workspace to inspect the relevant code, implement this change, and run the validation commands listed above. I reviewed the resulting diff and validation output before submitting.