fix(contacts): normalize custom field type labels#1983
Open
keilogic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #244.
This updates the contact model so custom vCard field types stored as
TYPE=x-...are shown to users without the transport-onlyx-prefix, then saved back with the prefix when they are not known vCard type values.The Android-style vCard sample from the issue now parses
TYPE=x-starýas the editable labelstarý, preserves standard labels such asprefandcell, and serializes an edited custom label back asTYPE=x-starý.Validation
npm cinpx ng test runbox7 --watch=false --browsers=FirefoxHeadless --include=src/app/contacts-app/contact.spec.tsfailed with2 FAILED, 23 SUCCESSbecause the model exposedx-starý/x-obsoleteand savedTYPE=starýnpx ng test runbox7 --watch=false --browsers=FirefoxHeadless --include=src/app/contacts-app/contact.spec.tspassed with25 SUCCESSnpx tsc -p src/tsconfig.app.json --noEmitnpx tsc -p src/tsconfig.spec.json --noEmitnpm run lint -- --quietnpm run policypassed for the current commits; it still reports existing historical commit-message warningsgit diff --check origin/master...HEADgit show --check --stat --oneline HEADnpx ng test runbox7 --watch=false --browsers=FirefoxHeadlesspassed with247 SUCCESSand 2 existing skipped testsSKIP_CHANGELOG=1; node src/build/pre-build.js; npx ng build --configuration production --base-href=/app/ runbox7; node src/build/post-build.jspassed with existing Angular/CommonJS/theming warnings; build hash391ab3d473a443c7AI Disclosure
I used OpenAI Codex to inspect the issue and current source, make the code/test changes, and run the validation commands listed above.