fix(calendar): make mobile calendar title fit#1982
Open
keilogic wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sat, May 23, 2020instead of the full weekday title.width: 100%inline header with a flex-safe container so the menu button, previous/next buttons, and title can share the viewport width.Closes #575
Testing
npm ciTS2339: Property 'mobileCalendarTitle' does not exist on type 'CalendarAppComponent'.npx ng test runbox7 --watch=false --browsers=FirefoxHeadless --include=src/app/calendar-app/calendar-app.component.spec.tsnpx tsc -p src/tsconfig.app.json --noEmitnpx tsc -p src/tsconfig.spec.json --noEmitnpm run lint -- --quietnpm run policy(branch commits OK; existing historical upstream commit-message warnings remain)git diff --check origin/master...HEADgit show --check --stat --oneline HEADSKIP_CHANGELOG=1,node src/build/pre-build.js,npx ng build --configuration production --base-href=/app/ runbox7,node src/build/post-build.js(existing Angular/CommonJS/theming warnings only; hasha0cd623a2e43ef64)AI Disclosure
I used OpenAI Codex to inspect the issue and current source, make the code/test changes, and run the validation commands listed above.