Add reload command to mini-browser#3
Open
slyjain wants to merge 1 commit into
Open
Conversation
Reloads the current page and waits for networkidle0 so SPAs fully render. Prints the current URL to stdout. Note: package-lock.json was not present in the repo and is being avoided.
There was a problem hiding this comment.
Pull request overview
Adds a reload command to the mb CLI so callers can reload the current tab, wait for networkidle0 (helpful for SPA rendering), and print the current URL afterward.
Changes:
- Register new
reloadcommand in the CLI command dispatcher. - Add
reloadto CLI help text under Navigation. - Implement
src/commands/reload.tsusingpage.reload({ waitUntil: "networkidle0", timeout: flags.timeout })and printpage.url().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/index.ts |
Wires reload into the command map and documents it in --help. |
src/commands/reload.ts |
Implements the reload behavior via Puppeteer connect/reload/print/disconnect. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloads the current page and waits for networkidle0 so SPAs fully render. Prints the current URL to stdout.
Note: package-lock.json was not present in the repo and is being avoided.