Remove Oracle Instant Client from Dockerfiles; Fix #419#421
Conversation
rdimaio
left a comment
There was a problem hiding this comment.
LGTM. On the backwards compatibility point: I think it's fine to remove the instant client from the latest versions of these containers, as they match the latest changes in the Rucio core code. That said, since 38 will be an LTS release, it might be worth keeping the instant client as part of this release at least, and then removing it from subsequent releases. @bari12 thoughts?
|
please rebase |
e680127 to
af76162
Compare
|
@dchristidis @bari12 Regarding the probes image specifically mentioned at the top, the following: https://github.com/rucio/probes/blob/main/common/check_oracle is currently still requiring Oracle Instant Client / thick mode (importing |
|
Wasn’t it the case that we couldn’t use thin mode at all at CERN? |
Is there any yes case here?:
I don't have access to ATLAS so I am walking in the dark here a bit. Maybe I could request a DaFab test instance to play with from "https://cern.service-now.com/service-portal?id=service_element&name=oracle-database-service" (if this is the service we expect to be using at Cern). |
|
Comment from our DBA from 31 July 2025:
|
Hmmm, probably then NNE is involved in which case this might be indeed a blocker. But if TLS / TCPS is used, then thin mode can support such encrypted connections with proper configuration. I'll pm you to check something about this. |
|
@bari12 Indeed after confirming with @dchristidis, the connections are using To avoid just reverting this, I suggest to reintroduce Instant Client, but in a cleaner/pinned way (via Oracle signed package verification). Maybe try to go even with I could work on this today. |
|
I started working on this and I'll have it ready by today to give it a check. |
Removes Oracle Instant Client and dependencies that have been specified as required by it only.
The affected containers are:
daemonsinitprobesserveruihowever, would we prefer to keep the client in some of those for backwards compatibility (e.g. in
probes)? Not sure. If so, I can leave it (may adding an inline comment that this needs to be removed in 2 years).