Introduce maintenance task to remove unconfirmed users#6088
Open
landongrindheim wants to merge 2 commits intomasterfrom
Open
Introduce maintenance task to remove unconfirmed users#6088landongrindheim wants to merge 2 commits intomasterfrom
landongrindheim wants to merge 2 commits intomasterfrom
Conversation
Sometimes accounts are created by someone other than the owner of an email address. In these cases, a User is created, but the account is never confirmed. If someone has been in this scenario for more than a month, we should remove the record in order to ensure the owner of the email is not contacted.
landongrindheim
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6088 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 476 477 +1
Lines 9785 9795 +10
=======================================
+ Hits 9515 9525 +10
Misses 270 270 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshenny
previously approved these changes
Nov 4, 2025
github-project-automation
Bot
moved this from Todo
to Ready
in RubyGems.org Pull Requests
jenshenny
reviewed
Nov 4, 2025
| UNCONFIRMED_USER_RETENTION_DAYS = 30.days | ||
|
|
||
| def collection | ||
| User |
Member
There was a problem hiding this comment.
Actually could this happen?
- User creates account long ago that has gems
- User recently changes email within 30 days but never confirmed it
- We delete their account
landongrindheim
dismissed
jenshenny’s stale review
The query is too broad and would remove users with legitimate ownerships.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes accounts are created by someone other than the owner of an email address. In these cases, a User is created, but the account is never confirmed. If someone has been in this scenario for more than a month, we should remove the record in order to ensure the owner of the email is not contacted.