Skip to content

Add GitLab OIDC provider support#5978

Draft
tachyons wants to merge 10 commits intorubygems:masterfrom
tachyons:feat/trusted_gitlab
Draft

Add GitLab OIDC provider support#5978
tachyons wants to merge 10 commits intorubygems:masterfrom
tachyons:feat/trusted_gitlab

Conversation

@tachyons
Copy link
Copy Markdown

@tachyons tachyons commented Sep 22, 2025

The changes add GitLab as a new OIDC trusted publisher, allowing gem publishing from GitLab CI/CD pipelines.

Goals:

  • Add GitLab CI as the supported OIDC provider

Non Goals for this iteration

  • Support for self managed instances
  • Attestation support

tachyons-gitlab and others added 10 commits September 22, 2025 14:59
The changes add GitLab as a new OIDC trusted publisher, allowing gem
publishing from GitLab CI/CD pipelines.
The commit refactors trusted publisher handling to support both GitHub
Actions and GitLab publishers in a more modular way. It adds publisher
type selection and provider-specific form components.
The changes modify the GitLab OIDC trusted publisher model to match
GitLab's token format, removing namespace_path and adding ref_path,
environment, and ci_config_ref_uri fields.
The changes add UI support for selecting different types of trusted
publishers (GitHub Actions, GitLab) when creating a new pending trusted
publisher. The form updates dynamically based on the selected provider
type.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 68.10811% with 59 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.02%. Comparing base (2b4f35a) to head (c494cf9).
⚠️ Report is 222 commits behind head on master.

Files with missing lines Patch % Lines
...s/oidc/trusted_publisher/gitlab/table_component.rb 0.00% 23 Missing ⚠️
...ts/oidc/trusted_publisher/gitlab/form_component.rb 0.00% 21 Missing ⚠️
app/models/oidc/trusted_publisher/gitlab.rb 93.67% 5 Missing ⚠️
app/models/oidc/provider.rb 50.00% 3 Missing ⚠️
...lers/oidc/pending_trusted_publishers_controller.rb 75.00% 2 Missing ⚠️
...lers/oidc/rubygem_trusted_publishers_controller.rb 85.71% 2 Missing ⚠️
app/helpers/rubygems_helper.rb 0.00% 1 Missing ⚠️
.../views/oidc/pending_trusted_publishers/new_view.rb 91.66% 1 Missing ⚠️
.../views/oidc/rubygem_trusted_publishers/new_view.rb 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5978      +/-   ##
==========================================
- Coverage   97.24%   94.02%   -3.22%     
==========================================
  Files         476      480       +4     
  Lines        9787    10062     +275     
==========================================
- Hits         9517     9461      -56     
- Misses        270      601     +331     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants