Remove MetaMethod and GhostMethod#1705
Open
Earlopain wants to merge 1 commit into
Open
Conversation
RDoc has no special handling for these. `MetaMethod` is unreferenced, and `GhostMethod` was only used for tomdoc.
There was a problem hiding this comment.
Pull request overview
This PR removes the RDoc::MetaMethod and RDoc::GhostMethod code objects, which no longer have any special handling in RDoc (and were unreferenced aside from TomDoc parsing). The TomDoc signature parsing now creates standard RDoc::AnyMethod instances instead of RDoc::GhostMethod.
Changes:
- Replace
RDoc::GhostMethodwithRDoc::AnyMethodwhen synthesizing methods from TomDoc signatures. - Delete the
RDoc::MetaMethodandRDoc::GhostMethodclass files. - Remove related autoload entries and inline documentation references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/rdoc/parser/ruby.rb | Uses RDoc::AnyMethod for TomDoc-derived method objects instead of GhostMethod. |
| lib/rdoc/code_object/meta_method.rb | Removes the unused RDoc::MetaMethod subclass. |
| lib/rdoc/code_object/ghost_method.rb | Removes the RDoc::GhostMethod subclass previously used only for TomDoc. |
| lib/rdoc/code_object.rb | Updates the code object hierarchy comment to drop removed classes. |
| lib/rdoc.rb | Removes autoloads for the deleted code object classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDoc has no special handling for these.
MetaMethodis unreferenced, andGhostMethodwas only used for tomdoc.