Move html characeter converting mechanism to regexp-handling#1570
Open
tompng wants to merge 1 commit into
Open
Move html characeter converting mechanism to regexp-handling#1570tompng wants to merge 1 commit into
tompng wants to merge 1 commit into
Conversation
`Text#to_html_characters` was a postprocess that converts ascii quotes/marks to multibyte characters. Postprocessing HTML to do thaat is not a good idea. Convert plain text node is better.
tompng
temporarily deployed
to
fork-preview-protection
GitHub Actions
Inactive
tompng
commented
Jan 19, 2026
| h[encoding] = { | ||
| :close_dquote => encode_fallback('”', encoding, '"'), | ||
| :close_squote => encode_fallback('’', encoding, '\''), | ||
| :copyright => encode_fallback('©', encoding, '(c)'), |
Member
Author
There was a problem hiding this comment.
I think html character is ©, not ©, but it's another issue.
Collaborator
|
🚀 Preview deployment available at: https://92299bff.rdoc-6cd.pages.dev (commit: 6eb654a) |
st0012
reviewed
May 12, 2026
|
|
||
| TO_HTML_CHARACTERS = Hash.new do |h, encoding| | ||
| h[encoding] = { | ||
| :close_dquote => encode_fallback('”', encoding, '"'), |
Member
There was a problem hiding this comment.
Can we use Ruby 1.9 hash syntax?
| :close_squote => encode_fallback('’', encoding, '\''), | ||
| :copyright => encode_fallback('©', encoding, '(c)'), | ||
| :ellipsis => encode_fallback('…', encoding, '...'), | ||
| :dot_ellipsis => encode_fallback('.…', encoding, '....'), |
Member
There was a problem hiding this comment.
nit: I think we can align this one too:
Suggested change
| :dot_ellipsis => encode_fallback('.…', encoding, '....'), | |
| :dot_ellipsis => encode_fallback('.…', encoding, '....'), |
| # Transcodes +character+ to +encoding+ with a +fallback+ character. | ||
|
|
||
| def self.encode_fallback(character, encoding, fallback) | ||
| character.encode(encoding, :fallback => { character => fallback }, |
Member
There was a problem hiding this comment.
nit: 1.9 hash syntax. Or we can do it via a cop in a separate PR too
| @insquotes = true | ||
| end | ||
| end | ||
| TO_HTML_CHARACTERS[quote.encoding][type] if type |
Member
There was a problem hiding this comment.
Could TO_HTML_CHARACTERS[quote.encoding] ever be nil and causes NoMethodError?
st0012
reviewed
May 12, 2026
| type = @in_dquote ? :close_dquote : :open_dquote | ||
| @in_dquote = !@in_dquote | ||
| when "'" | ||
| if @insquotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text#to_html_characterswas a postprocess that converts ascii quotes/marks to multibyte characters. Postprocessing HTML to do that is not a good idea. Convert plain text node with regexp-handling is better.