Skip to content

Add Net::Protocol::TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT#43

Merged
eregon merged 2 commits into
ruby:masterfrom
eregon:add_tcpsocket_has_open_timeout_constant
Dec 17, 2025
Merged

Add Net::Protocol::TCP_SOCKET_NEW_HAS_OPEN_TIMEOUT#43
eregon merged 2 commits into
ruby:masterfrom
eregon:add_tcpsocket_has_open_timeout_constant

Conversation

@eregon

@eregon eregon commented Dec 8, 2025

Copy link
Copy Markdown
Member
  • To find out efficiently if TCPSocket#initialize supports the open_timeout keyword argument.

From ruby/net-http#224 (comment)

* To find out efficiently if TCPSocket#initialize supports the open_timeout keyword argument.
@osyoyu

osyoyu commented Dec 8, 2025

Copy link
Copy Markdown

This looks good to me. 👍

@mohamedhafez

Copy link
Copy Markdown

Would also love to have this merged so I can use it in ruby/net-smtp#95

@eregon

eregon commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

net-protocol has no official maintainer so I'll merge this then.

@eregon

eregon commented Dec 17, 2025

Copy link
Copy Markdown
Member Author

cc @olleolleolle @hsbt @nobu since you recently merged to this repo.
It would be nice to have this in Ruby 4.0, how do we do that now that sync got disabled in ruby/ruby@2117e61 ?

@eregon eregon merged commit 3d4181c into ruby:master Dec 17, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants