Skip to content

🐛 Prevent trailing {0} in RawData validation #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevans merged 1 commit into from
Jun 9, 2026
+8 −1
Merged

🐛 Prevent trailing {0} in RawData validation #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/imap/command_data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def send_data(imap, tag) = data.each do _1.send_data(imap, tag) end

def validate
return unless data.last in RawText(data: text)
if text.rindex(/~?\{[1-9]\d*\+?\}\z/n)
if text.rindex(/\{\d+\+?\}\z/n)
raise DataFormatError, "RawData cannot end with literal continuation"
end
end
Expand Down
7 changes: 7 additions & 0 deletions test/net/imap/test_command_data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,13 @@ class RawDataTest < CommandDataTest
assert_raise(DataFormatError) do RawData.new(data: "~literal+ ~{123+}") end
raw = RawData.new(data: " {123} ")
assert_equal [RawText[" {123} "]], raw.data

assert_raise(DataFormatError) do RawData.new(data: "literal {0}") end
assert_raise(DataFormatError) do RawData.new(data: "literal+ {0+}") end
assert_raise(DataFormatError) do RawData.new(data: "~literal ~{0}") end
assert_raise(DataFormatError) do RawData.new(data: "~literal+ ~{0+}") end
raw = RawData.new(data: " {0} ")
assert_equal [RawText[" {0} "]], raw.data
end

data(
Expand Down
Loading