fix: preserve scope in consequential claims - #69
Merged
Conversation
Owner
Author
|
bugbot run |
ruby-dlee
force-pushed
the
fm/self-block-rootcause-s8
branch
from
August 2, 2026 04:57
2e5496b to
9bc7328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix unchecked scope collapse in both directions: firstmate must not turn one route's failure into a platform-wide blocker or one leg's success into a claim that a composite mechanism works. Ship one unified consequential-claim carrier in operating fundamentals principle 7 that records exact scope and every leg, requires direct end-to-end evidence or an explicit unverified label for positives, requires authoritative reference plus an independent safe route and narrowest result for blockers, blocks claims on unresolved directly relevant contradictions, and preserves target-outcome, critical-path, consequential-bypass rationale, and operation-failing-not-noise protections. Route the skill before making or relaying consequential success, failure, blocker, or capability claims; keep firstmate-owned and relayed blocker proof symmetric. Remove the obsolete one-load-bearing-assumption route and stale ownership pointers without deleting or merging crew-steering. Make the Lavish decision trigger fire before creating, repairing, or presenting a multi-option captain choice and preserve the durable non-browser protocol. Keep the aggregate branch net-neutral or smaller in both tracked lines and words, retain structural coverage for every required carrier concept and presentation trigger, and do not broaden the decision pretool gate, touch personal captain state, change machine-local Slack skills, or perform unrelated audit cleanup. The structural assertions prove contract presence, not behavioral firing.
What Changed
Risk Assessment
✅ Low: The corrective commit closes the unresolved-contradiction loophole, preserves the unified scoped-claim contract, and the aggregate branch remains smaller in tracked lines and words without touching forbidden surfaces.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
.agents/skills/operating-fundamentals/SKILL.md:53- The required criterion says the carrier “blocks claims on unresolved directly relevant contradictions,” but this hunk says a contradiction blocks the claim only until it is “reported unresolved.” That makes disclosure alone a route to resume the consequential claim while the contradiction still exists. Keep the claim blocked until the contradiction is reproduced/resolved or demonstrated to belong to a different scope; otherwise report only the unresolved observations, not the claim.🔧 Fix: Block claims on unresolved contradictory evidence
✅ Re-checked - no issues remain.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"✅ **Document** - passed
✅ No issues found.
🔧 **Lint** - 1 issue found → auto-fixed ✅
🔧 Fix: Remove unused operating-fundamentals test variable
✅ Re-checked - no issues remain.
✅ **Push** - passed
✅ No issues found.