fix(lavish): make surfaced answer commands independently runnable - #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix Firstmate's captain-facing Lavish decision command so every surfaced answer command runs from a shell where FM_HOME is unset, while preserving Lavish's fail-closed requirement to identify the fleet home. Always emit --home with the resolved, shell-quoted absolute home path instead of asking the captain to export FM_HOME once, because each durable decision must be independently runnable without hidden setup despite the slightly longer command. Update the authoritative lavish-decisions skill and keep the human README consistent without creating a second contract owner; find and fix any other producer of the defective captain-facing short form. Prove behavior by executing the actual surfaced command with FM_HOME unset, without touching the eight live decision boards. Do not run the repository's full local test suite because it drives real agent lifecycle tooling against a live fleet; skip the local test pipeline step and rely on clean-runner GitHub CI. The PR body must record the chosen always-explicit --home design and its reasoning.
What Changed
lavish-axi createemit captain-facing answer commands with a shell-quoted, resolved absolute--homepath so each command runs independently withFM_HOMEunset.FM_HOMEremoved and verifies the answer is saved.Risk Assessment
✅ Low: The change is narrowly scoped, emits a correctly shell-quoted explicit absolute home path, updates the authoritative skill and supporting README consistently, and adds source-level coverage that executes the surfaced command with FM_HOME unset.
Testing
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Test** - skipped
Step was skipped.
✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.