fix(watcher): absorb completed runs with declared pauses - #53
Merged
Conversation
ruby-dlee
force-pushed
the
fm/paused-stale-fix-p5
branch
from
July 31, 2026 15:34
fc90196 to
1bd0578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Stop a finished-but-waiting crewmate from re-triggering the wedge alarm on every watcher cycle. For stale-pane absorb purposes only, a terminal done/passed run-step plus a durable valid declared pause must be treated as expected idle without changing general run-step-over-log precedence. Preserve pause cadence markers while status remains declared paused and clear them only after the pause genuinely ends. Do not hide real wedges: stopped crew without a pause must surface immediately, active or failed runs must retain existing safety behavior, and aged declared pauses must resurface on the bounded long cadence. Add automated coverage for all three directions and leave unrelated known red-main failures untouched.
What Changed
Risk Assessment
✅ Low: The change is narrowly scoped and preserves run-step precedence while allowing only completed run-steps with a valid declared pause to use bounded pause resurfacing; active, failed, and unpaused stopped states remain surfaced.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"✅ **Document** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.