docs: add safe Lavish surface repair playbook - #45
Open
ruby-dlee wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Author a firstmate-loaded internal lavish-repair skill that safely diagnoses and repairs wedged Lavish decision surfaces. The workflow must prove the failing layer in cheapest-first order: HTTP serving, the known MaxListeners live-channel leak, a missing per-board poll listener, and only then the browser. It must prohibit fleet-wide pkill -f patterns with the concrete 2026-07-28 loss of 15 of 16 crews, require listing and argv inspection before explicit-PID signaling, prescribe least-destructive per-layer repair, preserve session URLs when re-serving the same source file, and explain that reports, worktrees, commits, and pushed PRs survive a crew kill while only the live agent session is lost. Keep it under .agents/skills with internal metadata, add the minimum section-13 load trigger and safety regression coverage, open a PR without merging, and do not conflate or fix the unrelated Behavior-test failure already red on main.
What Changed
lavish-repairskill with cheapest-first diagnosis and least-destructive recovery procedures for wedged Lavish surfaces.Risk Assessment
✅ Low: The change is a well-bounded internal skill and static regression contract that satisfies the required diagnosis order, explicit-PID safety gate, least-destructive repairs, stable session URLs, and crew-kill durability guidance without touching the unrelated existing failure.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"✅ **Document** - passed
✅ No issues found.
🔧 **Lint** - 1 issue found → auto-fixed ✅
🔧 Fix: Fix ShellCheck quoting in lavish repair assertions
✅ Re-checked - no issues remain.
✅ **Push** - passed
✅ No issues found.