Skip to content

test: align secondmate routing coverage with launch behavior - #44

Open
ruby-dlee wants to merge 8 commits into
mainfrom
fm/fm-ci-red-rootcause-c9
Open

test: align secondmate routing coverage with launch behavior#44
ruby-dlee wants to merge 8 commits into
mainfrom
fm/fm-ci-red-rootcause-c9

Conversation

@ruby-dlee

Copy link
Copy Markdown
Owner

Intent

Find the actual reason Firstmate's Behavior CI has failed on every recent main push, determine whether it is the same failure as the earlier occupied-Herdr assertion and identify the commit where it changed, then restore a green baseline without weakening coverage. PR #43's 45-to-90-minute timeout increase is explicitly not the answer to main's seven-minute assertion failure. If a recent deliberate behavior change made the test stale, update the test to assert the intended behavior and explain the proof. Keep shared tracked work on a feature branch, open a PR, do not merge it, and state whether PR #43 remains needed.

What Changed

  • Update secondmate routing fixtures to distinguish clean pre-routing homes from dirty homes and assert the intended enforce/off-mode behavior.
  • Preserve freshness-gate coverage with dedicated dirty-home cases in both routing modes.
  • Correct provisioning documentation to state that dirty, diverged, or unresolved secondmate homes are refused before launch.

Risk Assessment

✅ Low: The amended change preserves the corrected clean-home capability behavior and adds exactly two focused dirty incapable-home cases that verify freshness rejection precedes capability handling and endpoint creation in enforce and off modes.

Testing

Completed 1 recorded test check.

  • Outcome: ⚠️ 1 error across 1 run (1h22m32s)

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

🔧 **Review** - 1 issue found → auto-fixed ✅
  • 🚨 tests/fm-account-routing.test.sh:2224 - The required criterion says “restore a green baseline without weakening coverage,” but these replacements convert both incapable-home cases into clean-fixture capability/compatibility checks and remove the previous assertions that dirty secondmate homes stop at the freshness gate. Preserve the new clean-home expectations, but add separate dirty incapable-home cases for enforce and off modes so freshness ordering remains covered.

🔧 Fix: Restore dirty secondmate freshness coverage
✅ Re-checked - no issues remain.

⚠️ **Test** - 1 error
  • 🚨 tests failed with exit code 1
  • command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

@ruby-dlee
ruby-dlee force-pushed the fm/fm-ci-red-rootcause-c9 branch from 7d001a6 to bdd0848 Compare July 29, 2026 02:02
@ruby-dlee ruby-dlee closed this Jul 29, 2026
@ruby-dlee ruby-dlee reopened this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant