test: align secondmate routing coverage with launch behavior - #44
Open
ruby-dlee wants to merge 8 commits into
Open
test: align secondmate routing coverage with launch behavior#44ruby-dlee wants to merge 8 commits into
ruby-dlee wants to merge 8 commits into
Conversation
ruby-dlee
force-pushed
the
fm/fm-ci-red-rootcause-c9
branch
from
July 29, 2026 02:02
7d001a6 to
bdd0848
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Find the actual reason Firstmate's Behavior CI has failed on every recent main push, determine whether it is the same failure as the earlier occupied-Herdr assertion and identify the commit where it changed, then restore a green baseline without weakening coverage. PR #43's 45-to-90-minute timeout increase is explicitly not the answer to main's seven-minute assertion failure. If a recent deliberate behavior change made the test stale, update the test to assert the intended behavior and explain the proof. Keep shared tracked work on a feature branch, open a PR, do not merge it, and state whether PR #43 remains needed.
What Changed
Risk Assessment
✅ Low: The amended change preserves the corrected clean-home capability behavior and adds exactly two focused dirty incapable-home cases that verify freshness rejection precedes capability handling and endpoint creation in enforce and off modes.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
tests/fm-account-routing.test.sh:2224- The required criterion says “restore a green baseline without weakening coverage,” but these replacements convert both incapable-home cases into clean-fixture capability/compatibility checks and remove the previous assertions that dirty secondmate homes stop at the freshness gate. Preserve the new clean-home expectations, but add separate dirty incapable-home cases for enforce and off modes so freshness ordering remains covered.🔧 Fix: Restore dirty secondmate freshness coverage
✅ Re-checked - no issues remain.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.