fix: should not bundle react#102
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Rspack/Rsbuild build configuration in 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
This PR fixes the doc-ui library build so React-related subpath imports remain external. The previous exact externals matched
reactandreact-dom, but allowedreact-dom/clientfrom the Ant Design wave/render path to be bundled intodist/antd, which could conflict with the consuming site's React version.Validation
pnpm builddist/antd/index.jsimportsreact-dom/clientexternally and no longer contains inlinedreact-dom@...version-specific code.Related Links