fix(build): create server/web before copying web dist#3362
Merged
Conversation
make build-local-web fails in a fresh clone or worktree because server/web/ does not exist when cp -r runs. Ensure the parent directory exists first. Co-Authored-By: Claude Fable 5 <[email protected]>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesLocal web build
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying mycel with
|
| Latest commit: |
e133f71
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0fae3853.mycel.pages.dev |
| Branch Preview URL: | https://fix-makefile-fresh-clone.mycel.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make build-local-web fails in fresh clones/worktrees with
cp: server/web/dist: No such file or directorybecause theserver/web/parent directory only exists once the daemon embed stub has been created. Addmkdir -p server/webbefore the copy so the target builds from a pristine checkout.Part of #3334
🤖 Generated with Claude Code
Summary by CodeRabbit