Skip to content

fix(build): create server/web before copying web dist#3362

Merged
rpuneet merged 1 commit into
mainfrom
fix/makefile-fresh-clone
Jul 13, 2026
Merged

fix(build): create server/web before copying web dist#3362
rpuneet merged 1 commit into
mainfrom
fix/makefile-fresh-clone

Conversation

@rpuneet

@rpuneet rpuneet commented Jul 11, 2026

Copy link
Copy Markdown
Owner

make build-local-web fails in fresh clones/worktrees with cp: server/web/dist: No such file or directory because the server/web/ parent directory only exists once the daemon embed stub has been created. Add mkdir -p server/web before the copy so the target builds from a pristine checkout.

Part of #3334

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved local web builds by automatically creating the required web directory before assembling build files.
    • Prevented build failures when the target directory does not already exist.

make build-local-web fails in a fresh clone or worktree because
server/web/ does not exist when cp -r runs. Ensure the parent
directory exists first.

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4c8bd4d8-ed1e-4abe-81f3-694882087696

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea1877 and e133f71.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The build-local-web Makefile target now creates server/web before replacing its dist contents with the local web build output.

Changes

Local web build

Layer / File(s) Summary
Prepare web asset destination
Makefile
The build-local-web target adds mkdir -p server/web before removing and copying distribution files.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a rabbit in the build-room bright,
Making folders neat and right.
Web files hop from source to nest,
Then dist settles in for rest.
One small command, a smoother flight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the fix and issue, but it misses the required template sections for Summary, Changes, Test Plan, and Checklist. Reformat the PR body to include the template headings, add a Changes bullet, a Test Plan entry, and the checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main fix: creating server/web before copying web dist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/makefile-fresh-clone

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mycel with  Cloudflare Pages  Cloudflare Pages

Latest commit: e133f71
Status: ✅  Deploy successful!
Preview URL: https://0fae3853.mycel.pages.dev
Branch Preview URL: https://fix-makefile-fresh-clone.mycel.pages.dev

View logs

@rpuneet rpuneet merged commit 32e1de8 into main Jul 13, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant