Skip to content

Fix test_security tests using rmw_connextdds by disabling Monitoring 2.0#596

Open
fgallegosalido wants to merge 1 commit into
ros2:rollingfrom
fgallegosalido:feature/fix-security-tests-rmw-connextdds
Open

Fix test_security tests using rmw_connextdds by disabling Monitoring 2.0#596
fgallegosalido wants to merge 1 commit into
ros2:rollingfrom
fgallegosalido:feature/fix-security-tests-rmw-connextdds

Conversation

@fgallegosalido

Copy link
Copy Markdown
Contributor

Description

With the enabling of the Monitoring 2.0 Library in rolling (see ros2/rmw_connextdds#243), security tests are failing because the Monitoring Participant must be secured if other Participants are also secured.

To fix these tests, we explicitly disable Monitoring 2.0 through the environment variable RTI_MONITORING2_ENABLE.

Is this user-facing behavior change?

Tests in test_security using the rmw_connextdds will now pass again.

Did you use Generative AI?

No

Additional Information

Monitoring is specific to the Connext RMW. We don't need to test for it in system_tests.

@mergify

mergify Bot commented Jun 30, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@fujitatomoya can you launch a validation?

@jmachowinski

Copy link
Copy Markdown
Contributor

@fgallegosalido can you fix the DCO ?

@skyegalaxy skyegalaxy requested a review from fujitatomoya July 2, 2026 16:41
@jmachowinski

Copy link
Copy Markdown
Contributor

Pulls: #596
Gist: https://gist.githubusercontent.com/jmachowinski/6525b134911182ee8bf63e33af6e9635/raw/13437f4a0c796af0eca8b8f59e5b918d33cad8fa/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19707

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido

fgallegosalido commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@jmachowinski Sorry, I forgot to sign off the commit. I will wait for the CI to pass and open a new pr with the commit correctly signed. Is there any other way of doing it?

In any case, I'll try doing what the action says and see how it goes

@fgallegosalido fgallegosalido force-pushed the feature/fix-security-tests-rmw-connextdds branch from b276b3b to 6540f51 Compare July 2, 2026 17:01
@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@jmachowinski I think it is fixed. Let me know if this works.

@jmachowinski

jmachowinski commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@fgallegosalido

Looks good, now we just wait for CI ;-)

As the commit is identical the CI job is valid in any case.

@fgallegosalido

fgallegosalido commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@jmachowinski @fujitatomoya the Linux failure is not related to the Connext RMW. The Windows build is interesting, as it seems to have marked as failures tests that passed. Is that expected?

@jmachowinski

Copy link
Copy Markdown
Contributor

No, this looks like a infrastructure issue, I'll ping the infra team.

@jmachowinski

Copy link
Copy Markdown
Contributor

I just realized I ran the CI with the wrong parameters. Almost all test ran using FastDDS...

@jmachowinski

Copy link
Copy Markdown
Contributor

Pulls: #596
Gist: https://gist.githubusercontent.com/jmachowinski/0f922e6ee0631440fa36815351a94ee9/raw/13437f4a0c796af0eca8b8f59e5b918d33cad8fa/ros2.repos
BUILD args: --cmake-args -DRMW_IMPLEMENTATION=rmw_connextdds
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19723

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@jmachowinski the package gz_math_vendor couldn't be built. It seems the machine run out of memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants