Fix test_security tests using rmw_connextdds by disabling Monitoring 2.0#596
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
|
@fujitatomoya can you launch a validation? |
|
@fgallegosalido can you fix the DCO ? |
|
Pulls: #596 |
|
@jmachowinski Sorry, I forgot to sign off the commit. I will wait for the CI to pass and open a new pr with the commit correctly signed. Is there any other way of doing it? In any case, I'll try doing what the action says and see how it goes |
Signed-off-by: Francisco Gallego Salido <[email protected]>
b276b3b to
6540f51
Compare
|
@jmachowinski I think it is fixed. Let me know if this works. |
|
Looks good, now we just wait for CI ;-) As the commit is identical the CI job is valid in any case. |
|
@jmachowinski @fujitatomoya the Linux failure is not related to the Connext RMW. The Windows build is interesting, as it seems to have marked as failures tests that passed. Is that expected? |
|
No, this looks like a infrastructure issue, I'll ping the infra team. |
|
I just realized I ran the CI with the wrong parameters. Almost all test ran using FastDDS... |
|
Pulls: #596 |
|
@jmachowinski the package |
Description
With the enabling of the Monitoring 2.0 Library in rolling (see ros2/rmw_connextdds#243), security tests are failing because the Monitoring Participant must be secured if other Participants are also secured.
To fix these tests, we explicitly disable Monitoring 2.0 through the environment variable
RTI_MONITORING2_ENABLE.Is this user-facing behavior change?
Tests in
test_securityusing thermw_connextddswill now pass again.Did you use Generative AI?
No
Additional Information
Monitoring is specific to the Connext RMW. We don't need to test for it in
system_tests.