Add tests for Keyed types#568
Conversation
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
|
@fgallegosalido Would you mind rebasing this on top of #542 with:
|
|
@MiguelCompany I do not have permission to modify the branch |
|
@fgallegosalido The idea is that your branch (which you can modify) stems from the head of my branch, and contains additional commits with your work. This way, your PR will have the commits from both, and we could close my PR in favor of this one, and when this one is merged, we will both count as contributors. |
…RTPS and Connext RMWs Signed-off-by: Francisco Gallego Salido <[email protected]>
|
@MiguelCompany done. I've added tests for the |
|
CI with this repos file:
|
| string_ends_with("${interface_file}" ".msg" is_message) | ||
| if(is_message AND interface_ns STREQUAL "msg") | ||
| string_ends_with("${interface_file}" ".idl" is_idl) | ||
| if(is_idl AND interface_ns STREQUAL "msg") |
There was a problem hiding this comment.
is the same change required for srv to avoid the duplication?
There was a problem hiding this comment.
I think this probably related to #549, although it doesn't seem to be necessary for now and can be backported later
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Francisco Gallego Salido <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]> Signed-off-by: Francisco Gallego Salido <[email protected]>
|
@fujitatomoya changes applied. Let me know of anything else in order to be able to merge. |
|
New CI with this repos file:
|
5 participants
This adds support for the messages added by ros2/rcl_interfaces#173 to the
test_communicationpackage.Part of ros2/ros2#1538.