address warning: statement with no effect. (backport #559)

[mergify]

Description

see https://ci.ros2.org/job/ci_linux-aarch64/21795/clang-tidy/folder.-1643903456/source.270fa858-97ec-4b07-9c86-ec11c84b9370/#478

--- stderr: rcutils                                                            
In file included from /root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c:42:
/root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c: In function ‘rcutils_dir_iter_next’:
/root/ros2_ws/colcon_ws/src/ros2/rcutils/src/filesystem.c:478:67: warning: statement with no effect [-Wunused-value]
  478 |   RCUTILS_CHECK_FOR_NULL_WITH_MSG(iter->state, "iter is invalid", false);
      |                                                                   ^~~~~
/root/ros2_ws/colcon_ws/src/ros2/rcutils/include/rcutils/error_handling.h:215:7: note: in definition of macro ‘RCUTILS_CHECK_FOR_NULL_WITH_MSG’
  215 |       error_statement; \
      |       ^~~~~~~~~~~~~~~
---

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

we need to backport this fix to all downstream branches.

---

This is an automatic backport of pull request #559 done by [Mergify](https://mergify.com).

[jmachowinski]

Pulls: #560
Gist: https://gist.githubusercontent.com/jmachowinski/56b034986e4e6d2bfc863ad04cfd6e1c/raw/d55fbb0efcdb1ec6bc929108dff1f88ca610fbed/ros2.repos
BUILD args:
TEST args:
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19219

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[jmachowinski]

• Windows

[ahcorde]

• Windows

[jmachowinski]

• Windows