Add tests isolation in launch_testing_ros (backport #528)#534
Open
mergify[bot] wants to merge 1 commit into
Open
Add tests isolation in launch_testing_ros (backport #528)#534mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Julien Enoch <[email protected]> (cherry picked from commit 7879398)
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation to all tests launching a Node, in order to start a Zenoh router in case of
rmw_zenoh_cpp.More specifically, it fixes ros2/rmw_zenoh#918 which is failing in
test/examples/talker_listener_launch_test.pybecause the talker and the listener cannot find each other if a Zenoh router is not running.Is this user-facing behavior change?
No
Did you use Generative AI?
No
This is an automatic backport of pull request #528 done by [Mergify](https://mergify.com).