removed referene to filter_chain length and tf2_ros/transform_broadcaster header by aalmrad · Pull Request #1990 · ros-controls/ros2_controllers

aalmrad · 2025-11-04T22:38:27Z

could not find the filter_chain_'s length attribute so I removed it.
Also, replaced "tf2_ros/transform_broadcaster.hpp" by "tf2_ros/transform_broadcaster.h" in the #include list

…os-controls#1679)

…s-controls#1564) (ros-controls#1688) Co-authored-by: Bhagyesh Agresar <[email protected]>

…controls#1647) (ros-controls#1686) Co-authored-by: edward.ix <[email protected]>

…os-controls#1689) Co-authored-by: Pascal Auf der Maur <[email protected]>

…ros-controls#1691) Co-authored-by: Sai Kishor Kothakota <[email protected]>

…ort ros-controls#1697) (ros-controls#1699) Co-authored-by: Sai Kishor Kothakota <[email protected]>

…#1703) Co-authored-by: Christoph Fröhlich <[email protected]>

…1706) Co-authored-by: Christoph Fröhlich <[email protected]>

…ros-controls#1707) Co-authored-by: Christoph Fröhlich <[email protected]>

…1709) (ros-controls#1711) Co-authored-by: Arnav Kapoor <[email protected]>

…-controls#1719)

…ntrols#1727)

…#1723) Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>

…s-controls#1743) (ros-controls#1744) Co-authored-by: Sai Kishor Kothakota <[email protected]>

…backport ros-controls#1741) (ros-controls#1747) Co-authored-by: Julia Jia <[email protected]>

…ce support (backport ros-controls#1748) (ros-controls#1752) Co-authored-by: Julia Jia <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>

…s-controls#1762) Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>

…s#1766) Co-authored-by: Christoph Fröhlich <[email protected]>

…1585) (ros-controls#1769) Co-authored-by: Victor Coutinho Vieira Santos <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>

…ros-controls#1712) (ros-controls#1771) Co-authored-by: Nitin Maurya <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>

…os-controls#1779) Co-authored-by: Narukara <[email protected]>

Co-authored-by: mosfet80 <[email protected]>

…s-controls#1950)

…#1960) (ros-controls#1962)

…os-controls#1755) (backport ros-controls#1820) (ros-controls#1988)

mergify · 2025-11-04T22:39:06Z

This pull request is in conflict. Could you fix it @aalmrad?

christophfroehlich · 2025-11-10T16:51:27Z

I think this is obsolete, right?

aalmrad · 2025-11-10T17:02:37Z

@christophfroehlich these issues are breaking my build although i am using the latest commits of the jazzy branch

christophfroehlich · 2025-11-10T17:11:39Z

On which distro are you trying to build? Have you followed the build instructions, and use the correct branches of all relevant repos?

aalmrad · 2025-11-10T17:19:38Z

i have cloned the jazzy branch of the repository before building my workspace

christophfroehlich · 2025-11-10T17:25:09Z

please read carefully, you also have to use the correct branches of other repos from the repos file.
And you'll need to update ros-jazzy-filters according to your commits to have the filter_length API from ros/filters#90.

aalmrad · 2025-11-10T23:30:21Z

@christophfroehlich upgrading the tf2_ros and filters packages solved the issue. Thanks!

mergify Bot and others added 30 commits May 12, 2025 21:21

Add Kilted Kaiju and branch for Jazzy (backport ros-controls#1646) (r…

5954dc4

…os-controls#1679)

Simplify on_set_chained_mode avoiding cpplint warnings (backport ro…

0e84da4

…s-controls#1564) (ros-controls#1688) Co-authored-by: Bhagyesh Agresar <[email protected]>

Add multiplier support to ForceTorqueSensorBroadcaster (backport ros-…

2d4359c

…controls#1647) (ros-controls#1686) Co-authored-by: edward.ix <[email protected]>

[Pid] Add enable_feedforward parameter (backport ros-controls#1553) (r…

b0128fe

…os-controls#1689) Co-authored-by: Pascal Auf der Maur <[email protected]>

Use warning attribute of RcutilsLogger (backport ros-controls#1690) (…

2a19c4d

…ros-controls#1691) Co-authored-by: Sai Kishor Kothakota <[email protected]>

Update changelogs

84450dd

4.25.0

6efe723

Use target_link_libraries instead of ament_target_dependencies (backp…

9f128a3

…ort ros-controls#1697) (ros-controls#1699) Co-authored-by: Sai Kishor Kothakota <[email protected]>

Cleanup and grooming of CI (backport ros-controls#1701) (ros-controls…

2c6c3c8

…#1703) Co-authored-by: Christoph Fröhlich <[email protected]>

Remove CMAKE_CXX_STANDARD (backport ros-controls#1704) (ros-controls#…

90ed757

…1706) Co-authored-by: Christoph Fröhlich <[email protected]>

Fix JSB+GPIO CMakeLists and dependencies (backport ros-controls#1705) (…

080299a

…ros-controls#1707) Co-authored-by: Christoph Fröhlich <[email protected]>

Reset both sec and nanosec in time_from_start (backport ros-controls#…

7df20f6

…1709) (ros-controls#1711) Co-authored-by: Arnav Kapoor <[email protected]>

Add missing github_url to rst files (backport ros-controls#1717) (ros…

4b50c76

…-controls#1719)

Bump version of pre-commit hooks (backport ros-controls#1725) (ros-co…

fa4f95b

…ntrols#1727)

Fix DiffDrive claiming state when open_loop is set (ros-controls#1730)

e188bf9

Fix steering_controllers_library docs (ros-controls#1734)

ae05ed4

JTC: Use std::atomic<bool> (backport ros-controls#1720) (ros-controls…

ccc91f3

…#1723) Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>

Update changelogs

d90d2e6

4.26.0

c18c7f5

Set enable_feedforward parameter in the respective tests (backport ro…

9683ad4

…s-controls#1743) (ros-controls#1744) Co-authored-by: Sai Kishor Kothakota <[email protected]>

Revert temporary logging changes added for CI timeout investigation (…

9bc49d0

…backport ros-controls#1741) (ros-controls#1747) Co-authored-by: Julia Jia <[email protected]>

[JTC Doc] Update PID documentation for effort related command interfa…

621e896

…ce support (backport ros-controls#1748) (ros-controls#1752) Co-authored-by: Julia Jia <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>

Add new AntiWindup parameters to JTC (backport ros-controls#1759) (ro…

8f8880e

…s-controls#1762) Co-authored-by: Christoph Fröhlich <[email protected]> Co-authored-by: Sai Kishor Kothakota <[email protected]>

Fix atomic variables in JTC (backport ros-controls#1749) (ros-control…

22e925d

…s#1766) Co-authored-by: Christoph Fröhlich <[email protected]>

Add new members for PID controller parameters (backport ros-controls#…

e434fe2

…1585) (ros-controls#1769) Co-authored-by: Victor Coutinho Vieira Santos <[email protected]> Co-authored-by: Christoph Fröhlich <[email protected]>

Added Swerve Drive Kinematics in mobile_robot_kinematics.rst (backport …

5dd920a

…ros-controls#1712) (ros-controls#1771) Co-authored-by: Nitin Maurya <[email protected]> Co-authored-by: Christoph Froehlich <[email protected]>

Update changelogs

7c06eb8

4.27.0

9c48a5d

Fix SteeringOdometry calculation error (backport ros-controls#1777) (r…

403b5c4

…os-controls#1779) Co-authored-by: Narukara <[email protected]>

Fix cmake deprecation (backport ros-controls#1780) (ros-controls#1782)

29a75bb

Co-authored-by: mosfet80 <[email protected]>

mergify Bot and others added 13 commits October 6, 2025 09:57

[CI] Use YAML anchors (backport ros-controls#1953) (ros-controls#1955)

05d7249

Remove unused get_state_msg method (backport ros-controls#1949) (ro…

1aad51b

…s-controls#1950)

Fix JTC crashing when shutdown while executing (backport ros-controls…

8287413

…#1960) (ros-controls#1962)

Fix upstream Pid class deprecation warnings (ros-controls#1959)

8b9a223

[CI] Use kilted branch of control_toolbox (backport ros-controls#1963) (

6c81293

ros-controls#1965)

fix issue of not listing new JTCs (backport ros-controls#1891) (ros-c…

708f831

…ontrols#1969)

Update changelog

8fbc30a

4.33.1

5b1b0f9

Bump version of pre-commit hooks (backport ros-controls#1974) (ros-co…

1a4e19a

…ntrols#1976)

📝 Remove wrong information about trajectory replacement (ros-controls…

cdcacb5

…#1979)

Fix integer literal for size_t (backport ros-controls#1986) (ros-cont…

8676ab0

…rols#1987)

Add time_from_start to action feedback and state message (cherry-pick r…

e78e1ee

…os-controls#1755) (backport ros-controls#1820) (ros-controls#1988)

removed referene to filter_chain length

a775763

github-actions Bot requested review from LukasMacha97, VX792, destogl, erickisos, rosterloh, saikishor and xguay November 4, 2025 22:38

adjusted reference to tf2_ros/transform_broadcaster header file

f9166eb

aalmrad changed the title ~~removed referene to filter_chain length~~ removed referene to filter_chain length and tf2_ros/transform_broadcaster header Nov 4, 2025

christophfroehlich closed this Nov 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

removed referene to filter_chain length and tf2_ros/transform_broadcaster header#1990

removed referene to filter_chain length and tf2_ros/transform_broadcaster header#1990
aalmrad wants to merge 108 commits into
ros-controls:masterfrom
aalmrad:jazzy_bugs

aalmrad commented Nov 4, 2025 •

edited

Loading

Uh oh!

mergify Bot commented Nov 4, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

aalmrad commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Nov 4, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

christophfroehlich commented Nov 10, 2025

Uh oh!

aalmrad commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aalmrad commented Nov 4, 2025 •

edited

Loading