Skip to content

feat: support CMD as prefix for keybindings in macOS #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erickgnavar wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

feat: support CMD as prefix for keybindings in macOS #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/input/keybindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,27 @@ pub fn handle_key(
let ctrl = modifiers.state().control_key();
let shift = modifiers.state().shift_key();
let alt = modifiers.state().alt_key();
handle_key_inner(

// On macOS, Cmd (super) is the app-shortcut modifier (equivalent to Ctrl elsewhere).
let cmd = cfg!(target_os = "macos") && modifiers.state().super_key();

let action = handle_key_inner(
&event.logical_key,
ctrl,
ctrl || cmd,
shift,
alt,
mode,
grid_cols,
grid_rows,
application_cursor_keys,
)
);

// macOS: Cmd+key that doesn't match a shortcut is consumed, not forwarded to PTY.
if cmd && !ctrl && matches!(action, Action::SendToPty(_)) {

@roramirez roramirez May 28, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if cmd && !ctrl && matches!(action, Action::SendToPty(_)) {
// macOS: Consume any Cmd+key that has no binding, even when Ctrl is also held.
// Without this, Cmd+Ctrl+<unmapped> would leak a control byte to the PTY.
if cmd && matches!(action, Action::SendToPty(_)) {

These two modifiers are orthogonal — CTRL and SUPER should be independent bits with no exclusion logic between them. The !ctrl guard should be dropped.

Also, I would change the comment mentioned before

Action::None
} else {
action
}
}

pub fn handle_ctrl_w(event: &KeyEvent) -> Action {
Expand Down