Skip to content

ci: Remove nostril from excepted package licenses#398

Merged
cassidyjames merged 2 commits into
mainfrom
cassidyjames/license-nostril
Jul 1, 2026
Merged

ci: Remove nostril from excepted package licenses#398
cassidyjames merged 2 commits into
mainfrom
cassidyjames/license-nostril

Conversation

@cassidyjames

@cassidyjames cassidyjames commented Jun 30, 2026

Copy link
Copy Markdown
Member

It was removed in #391, so we don't need it in the license-check workflow anymore.

Summary by CodeRabbit

  • Chores
    • Updated license-check settings so one Python dependency is now included in license policy validation instead of being skipped.

It was removed in #391, so we don't need it in the license-check
workflow anymore.
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9407aab0-2e2c-455f-8316-64440a2c2689

📥 Commits

Reviewing files that changed from the base of the PR and between e8224fa and cf8ca62.

📒 Files selected for processing (1)
  • .github/workflows/license-check-python.yml

📝 Walkthrough

Walkthrough

The GitHub Actions license-check workflow for Python was updated to remove the nostril package from the license policy exemption list, both in the explanatory comment and the pip-licenses ignore-packages argument, so it is now subject to license evaluation.

Changes

License Check Workflow Update

Layer / File(s) Summary
Remove nostril from license ignore list
.github/workflows/license-check-python.yml
Removed nostril from the pending license policy review comment and the pip-licenses --ignore-packages list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main CI license-check change and identifies nostril as the package being removed from the exception list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cassidyjames/license-nostril

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cassidyjames cassidyjames merged commit f7fc4ca into main Jul 1, 2026
13 checks passed
@cassidyjames cassidyjames deleted the cassidyjames/license-nostril branch July 1, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant