Remove unused exports/dead code from client#784
Draft
taobojlen wants to merge 2 commits into
Draft
Conversation
Add knip and a `knip` npm script to find unused files, exports, and dependencies in the client. knip.json relies on knip's Vite / Vitest / Storybook / ESLint / Tailwind / PostCSS plugin auto-detection, ignores the generated GraphQL types (src/graphql/generated.ts), and ignores @types/google.maps (used as an ambient global namespace, which knip can't trace via imports). Remove dependencies with no references anywhere in the source tree: - framer-motion, jsonpointer, papaparse, react-markdown, react-router-hash-link, validator - @eslint/js (not imported by the flat config; bundled by eslint itself) - orphaned/obsolete types: @types/papaparse, @types/react-router-hash-link, @types/validator (their runtime packages were removed) and @types/recharts (recharts ships its own type definitions) Kept web-vitals — it's loaded via a dynamic import in reportWebVitals.js. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
This PR uses Knip to remove a lot of unused exports from
client/. Knip detects places where weexportsomething that it never imported.Once I removed the unnecessary exports, then eslint flagged a lot of dead code -- so I deleted it.
Tests
The best evidence that this doesn't break anything is that our build still works!