Cleanups around kernel side of Require - #22292
Open
SkySkimmer wants to merge 3 commits into
Open
Conversation
This lets us remove some code to check that the library isn't already loaded since we won't rerun the kernel load at module and section end.
…me twice Safe_typing.close_section replays Requires in a strange way so gets an internal flag to avoid the error. Could probably be done in a better way but would need to understand exactly what needs and doesn't need replaying.
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
Author
|
This breaks unimath because it breaks interleaving of Global Unset Universe Checking: (* file1 *)
Global Unset Universe Checking.(* file2 *)
Require file1.
Universe u. Constraint u < u.(* file3 *)
Require file2. (* error cannot enforce u < u in PR *) |
kinda dubious behaviour but easy to restore so why not
SkySkimmer
added
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Member
|
Can we get a test for this behaviour? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can remove some weird code checking that a required library already exists by moving it out of the libobject system.
We also enforce in the kernel that the imported library doesn't already exist instead of doing whatever it does in master.