Split some primitive notation code from notation.ml - #20926
Merged
Conversation
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
SkySkimmer
added a commit
to SkySkimmer/bignums
that referenced
this pull request
Jul 18, 2025
SkySkimmer
added a commit
to SkySkimmer/rocq-lsp
that referenced
this pull request
Jul 18, 2025
SkySkimmer
added a commit
to SkySkimmer/rocq-lsp
that referenced
this pull request
Jul 18, 2025
SkySkimmer
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
proux01
approved these changes
Jul 29, 2025
Some is still in notation.ml because it deals with scopes and synchronized state.
proux01
added
the
request: full CI
coqbot-app
Bot
removed
the
request: full CI
Contributor
|
@coqbot merge now |
Contributor
|
@proux01: Please take care of the following overlays:
|
proux01
added a commit
to rocq-community/bignums
that referenced
this pull request
Jul 29, 2025
Adapt to rocq-prover/rocq#20926 (code movement)
proux01
added a commit
to rocq-community/rocq-lsp
that referenced
this pull request
Jul 29, 2025
Adapt to rocq-prover/rocq#20926 (notations code movement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some is still in notation.ml because it deals with scopes and synchronized state.
Overlays: