Skip to content

Respect synterp/interp phase split #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkySkimmer merged 2 commits into from
Jul 15, 2025
Merged

Respect synterp/interp phase split #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f076842
move declare_scope call into declare_numeral_interpreter and add stag…
SkySkimmer Jul 15, 2025
889f675
Stop adding interp object at link time
SkySkimmer Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 24 additions & 11 deletions plugin/bignums_syntax.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,34 @@ let bigN_list_of_constructors =
in
build 0

let cache_bignums o =
Notation.declare_scope o.Notation.pt_scope;
Notation.enable_prim_token_interpretation o

let bignums_obj =
Libobject.declare_object @@
Libobject.superglobal_object_nodischarge "bignums_obj"
~cache:cache_bignums
~subst:None

let declare_numeral_interpreter uid sc dir interp (patl,uninterp,b) =
let open Notation in
register_bignumeral_interpretation uid (interp,uninterp);
enable_prim_token_interpretation { pt_local = false;
pt_scope = sc;
pt_interp_info = Uid uid;
pt_required = dir;
pt_refs = patl;
pt_in_match = b }
(* unsynchronized state *)
Notation.register_bignumeral_interpretation uid (interp,uninterp);
let interp () = Lib.add_leaf (bignums_obj {
(* we wrap in out own object (to get superglobal instead of export),
so we pass local to the Notation layer *)
pt_local = true;
pt_scope = sc;
pt_interp_info = Uid uid;
pt_required = dir;
pt_refs = patl;
pt_in_match = b;
})
in
Mltop.declare_cache_obj_full (CacheObj { synterp = (fun () -> ()); interp; }) "coq-bignums.plugin"

(* Actually declares the interpreter for bigN *)
let () =
Notation.declare_scope bigN_scope;
declare_numeral_interpreter "bignums.bigN" bigN_scope
(bigN_path, bigN_module)
interp_bigN
Expand Down Expand Up @@ -241,7 +256,6 @@ let uninterp_bigZ (AnyGlobConstr rc) =

(* Actually declares the interpreter for bigZ *)
let () =
Notation.declare_scope bigZ_scope;
declare_numeral_interpreter "bignums.bigZ" bigZ_scope
(bigZ_path, bigZ_module)
interp_bigZ
Expand All @@ -263,7 +277,6 @@ let uninterp_bigQ (AnyGlobConstr rc) =

(* Actually declares the interpreter for bigQ *)
let () =
Notation.declare_scope bigQ_scope;
declare_numeral_interpreter "bignums.bigQ" bigQ_scope
(bigQ_path, bigQ_module)
interp_bigQ
Expand Down