feat(loop): formal issue approval via backlog → planned labels (owner-only) - #72
Merged
Merged
Conversation
…r-only) Replace the implicit 'module:* label = approved work' convention with an explicit two-label workflow: - backlog: filed, not approved — default for every new issue, including issues agents file themselves. The loop never touches it. - planned: the owner's formal approval; assigned ONLY by the owner, never by agents/bots. ADVANCE now requires planned AND module:* (module stays the routing/boundary signal, not approval). Wired through: docs/USAGE.md (canonical description + historical note), pr-loop.md + pr-loop-self.md (STEP 0 cadence counts and ADVANCE filter, plus an explicit 'never assign planned' guard in the armed prompt), seed-issues.sh (bootstraps both labels; seeded tickets default to backlog), setup SKILL (consumer onboarding creates the labels and explains the gate). Labels already created in this repo; cockpit Phase 3 (#68) restructured as a backlog tracker with a Blocked-by chain (#69 -> #70 -> #71) as the first consumer of the new workflow. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01NTZEsfFT4mrZpv8CY67Frd
robercano
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes a formal issue-approval workflow, replacing the implicit
module:*-label-as-approval convention:backlog— filed, not approved. Default for every new issue, including issues agents file themselves. The loop never touches it.planned— the owner's formal approval. Assigned only by the owner — the armed loop prompts now carry an explicit "never assign planned" guard.module:*— unchanged role: routing + worker boundary, not approval. ADVANCE requiresplannedANDmodule:*.Wired through:
docs/USAGE.md(canonical spec + migration note for repos predating the split), bothpr-loopcommand prompts (STEP 0 cadence + ADVANCE filter),seed-issues.sh(creates both labels; seeded tickets defaultbacklog), setup SKILL (consumers get the labels + explanation at onboarding).Already applied live in this repo: labels created; cockpit Phase 3 restructured — #68 is now a
backlogtracking issue over the Blocked-by chain #69 → #70 → #71, each awaiting the owner'splannedpromotion.Self gates green (build/lint/test incl. fan-out smoke).
🤖 Generated with Claude Code