Skip to content

feat(loop): formal issue approval via backlog → planned labels (owner-only) - #72

Merged
robercano-ghbot merged 1 commit into
mainfrom
feat/issue-approval-labels
Jul 7, 2026
Merged

feat(loop): formal issue approval via backlog → planned labels (owner-only)#72
robercano-ghbot merged 1 commit into
mainfrom
feat/issue-approval-labels

Conversation

@robercano-ghbot

Copy link
Copy Markdown
Collaborator

Establishes a formal issue-approval workflow, replacing the implicit module:*-label-as-approval convention:

  • backlog — filed, not approved. Default for every new issue, including issues agents file themselves. The loop never touches it.
  • planned — the owner's formal approval. Assigned only by the owner — the armed loop prompts now carry an explicit "never assign planned" guard.
  • module:* — unchanged role: routing + worker boundary, not approval. ADVANCE requires planned AND module:*.

Wired through: docs/USAGE.md (canonical spec + migration note for repos predating the split), both pr-loop command prompts (STEP 0 cadence + ADVANCE filter), seed-issues.sh (creates both labels; seeded tickets default backlog), setup SKILL (consumers get the labels + explanation at onboarding).

Already applied live in this repo: labels created; cockpit Phase 3 restructured — #68 is now a backlog tracking issue over the Blocked-by chain #69#70#71, each awaiting the owner's planned promotion.

Self gates green (build/lint/test incl. fan-out smoke).

🤖 Generated with Claude Code

…r-only)

Replace the implicit 'module:* label = approved work' convention with an
explicit two-label workflow:
- backlog: filed, not approved — default for every new issue, including
  issues agents file themselves. The loop never touches it.
- planned: the owner's formal approval; assigned ONLY by the owner, never by
  agents/bots. ADVANCE now requires planned AND module:* (module stays the
  routing/boundary signal, not approval).

Wired through: docs/USAGE.md (canonical description + historical note),
pr-loop.md + pr-loop-self.md (STEP 0 cadence counts and ADVANCE filter, plus
an explicit 'never assign planned' guard in the armed prompt), seed-issues.sh
(bootstraps both labels; seeded tickets default to backlog), setup SKILL
(consumer onboarding creates the labels and explains the gate).

Labels already created in this repo; cockpit Phase 3 (#68) restructured as a
backlog tracker with a Blocked-by chain (#69 -> #70 -> #71) as the first
consumer of the new workflow.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
Claude-Session: https://claude.ai/code/session_01NTZEsfFT4mrZpv8CY67Frd
@robercano-ghbot
robercano-ghbot merged commit 4634a6c into main Jul 7, 2026
18 checks passed
@robercano-ghbot
robercano-ghbot deleted the feat/issue-approval-labels branch July 7, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants