Convert Warrington Council to use plain JSON parser#2134
Open
alpriest wants to merge 7 commits into
Open
Conversation
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@uk_bin_collection/uk_bin_collection/councils/WarringtonBoroughCouncil.py`:
- Around line 28-31: The bin_collection.get("schedule", []) call silently
defaults to an empty list when the "schedule" key is missing, which masks
upstream API changes and produces incorrect results. Instead of using a default
empty list, add explicit error checking that raises an exception (such as
KeyError or ValueError) if "schedule" is missing or malformed, allowing the
parser to fail fast and alert developers to schema drift. This change should
apply to the loop iteration over bin_collection data in the collection
processing logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff332c49-3121-463f-9ad8-91394121c4a5
📒 Files selected for processing (2)
uk_bin_collection/uk_bin_collection/common.pyuk_bin_collection/uk_bin_collection/councils/WarringtonBoroughCouncil.py
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@uk_bin_collection/uk_bin_collection/councils/WarringtonBoroughCouncil.py`:
- Around line 23-24: Remove the premature validation check at lines 23-24 in
WarringtonBoroughCouncil.py that attempts to validate the `schedule` variable
using `isinstance(schedule, list)` before it is defined. This check references
an undefined variable and will cause a NameError at runtime. The same validation
is already correctly implemented at lines 31-33 after the `schedule` variable is
extracted from the response, so delete the duplicate lines 23-24 entirely.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f20dfebb-d700-4514-b1fe-0de3bfdf2257
📒 Files selected for processing (1)
uk_bin_collection/uk_bin_collection/councils/WarringtonBoroughCouncil.py
Comment on lines
+23
to
+24
| if not isinstance(schedule, list): | ||
| raise ValueError("Unexpected Warrington response: missing/invalid 'schedule'") |
Contributor
There was a problem hiding this comment.
Remove premature validation that references undefined variable.
Lines 23-24 check schedule before it's defined at line 31, causing a NameError at runtime. The validation is correctly placed at lines 31-33 after schedule is extracted from the response. Delete lines 23-24 entirely.
🐛 Proposed fix
uri = f"https://www.warrington.gov.uk/bin-collections/get-jobs/{user_uprn}"
-if not isinstance(schedule, list):
- raise ValueError("Unexpected Warrington response: missing/invalid 'schedule'")
response = requests.get(uri, headers=HEADERS, timeout=30)🧰 Tools
🪛 Ruff (0.15.17)
[error] 23-23: Undefined name schedule
(F821)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@uk_bin_collection/uk_bin_collection/councils/WarringtonBoroughCouncil.py`
around lines 23 - 24, Remove the premature validation check at lines 23-24 in
WarringtonBoroughCouncil.py that attempts to validate the `schedule` variable
using `isinstance(schedule, list)` before it is defined. This check references
an undefined variable and will cause a NameError at runtime. The same validation
is already correctly implemented at lines 31-33 after the `schedule` variable is
extracted from the response, so delete the duplicate lines 23-24 entirely.
Source: Linters/SAST tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Warrington Council data consumer was broken. Warrington Council return formatted JSON for the API now (perhaps they changed), so this PR switches out the previous Selenium browser for a simple JSON parser.
Summary by CodeRabbit