Skip to content

fix: update input.json for East Ayrshire Council#2123

Open
dodger421 wants to merge 1 commit into
robbrad:masterfrom
dodger421:master
Open

fix: update input.json for East Ayrshire Council#2123
dodger421 wants to merge 1 commit into
robbrad:masterfrom
dodger421:master

Conversation

@dodger421

@dodger421 dodger421 commented Jun 7, 2026

Copy link
Copy Markdown

The changes to input.json from #2081 were not applied so the config flow was still asking for the UPRN and failing because the council script now expects a full address.

This PR updates input.json to match the changes in #2081.

Summary by CodeRabbit

  • Bug Fixes
    • Updated East Ayrshire Council service to accept postcode and house number input instead of requiring UPRN, improving accessibility for users in that area.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR updates the test fixture configuration for EastAyrshireCouncil in the input test data. The parser's test entry is changed to use house_number and postcode as inputs instead of UPRN, with corresponding updates to API behavior flags and documentation metadata to reflect the ReCollect API integration pattern.

Changes

Test Fixture Configuration Update

Layer / File(s) Summary
EastAyrshireCouncil ReCollect API migration
uk_bin_collection/tests/input.json
Test fixture configuration is updated to specify house_number and postcode inputs, enables skip_get_url flag, adds wiki_command_url_override, and updates wiki_name and wiki_note to reflect the new ReCollect API input pattern and behavior, removing the prior UPRN-based configuration guidance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A parser takes flight on the wind,
From UPRN chains, now gently unpinned,
With postcode and house number clear,
ReCollect's API draws ever near,
One test config tweaked, the path realigned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically summarizes the main change: updating the input.json configuration file for East Ayrshire Council to align with script modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dodger421 dodger421 changed the title Update input.json for East Ayrshire Council fix: update input.json for East Ayrshire Council Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant