[codex] Add TypeScript starter app smoke tests#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This adds small, variant-local smoke tests for the split TypeScript starter apps:
typescript/starter_apps/node/basictypescript/starter_apps/node/with_draftertypescript/starter_apps/nextjs/basictypescript/starter_apps/nextjs/with_drafterThe tests stay focused on starter-app behavior rather than re-testing core engine semantics.
Why
We split the starter apps into
basicandwith_draftervariants, and these examples need lightweight coverage that proves the starter wiring still behaves as documented without depending on the older monolithic test shape.Behavior covered
sessionId/inputreturns a validation errorsessionIdpreserves checkpoint behavior across turnshistoryreplay works when no checkpoint is savedwith_draftervariants additionally cover:Implementation notes
testscript.Validation
typescript/starter_apps/node/basic:npm test,npm run typechecktypescript/starter_apps/node/with_drafter:npm test,npm run typechecktypescript/starter_apps/nextjs/basic:npm test,npm run typecheck,npm run buildtypescript/starter_apps/nextjs/with_drafter:npm test,npm run typecheck,npm run buildOne temporary typecheck failure in
nextjs/with_drafterwas resolved by rerunning afternext buildgenerated.next/types; the final rerun passed cleanly.