Route-level error reporting in error.tsx#847
Open
deslawson wants to merge 1 commit into
Hidden character warning
The head ref may contain hidden characters: "Bug]-error.tsx-records-breadcrumb-but-never-calls-reportError()-\u2014-errors-silently-dropped-#712"
Open
Conversation
|
@deslawson Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict |
1 similar comment
Contributor
|
Kindly resolve conflict |
Added errorReportingService.reportError(error, ...) call inside the useEffect of src/app/error.tsx, mirroring the pattern in global-error.tsx. The error report includes the full error object, componentStack, and the digest prop when available. Previously, route-level errors only created a breadcrumb without reaching the monitoring backend, making production error triage impossible for the majority of application errors. A corresponding test file (src/app/__tests__/error.test.tsx) asserts that reportError and addBreadcrumb are both called when the error boundary catches an error. Closes rinafcode#712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added errorReportingService.reportError(error, ...) call inside the useEffect of src/app/error.tsx, mirroring the pattern in global-error.tsx. The error report includes the full error object, componentStack, and the digest prop when available. Previously, route-level errors only created a breadcrumb without reaching the monitoring backend, making production error triage impossible for the majority of application errors. A corresponding test file (src/app/tests/error.test.tsx) asserts that reportError and addBreadcrumb are both called when the error boundary catches an error.
Closes #712
Description
Brief description of changes
Related Issue
Closes #
Type of Change
Checklist