Skip to content

fix: implement environment-aware error boundary security#846

Open
Nacho1499 wants to merge 1 commit into
rinafcode:mainfrom
Nacho1499:fix/Error-boundary
Open

fix: implement environment-aware error boundary security#846
Nacho1499 wants to merge 1 commit into
rinafcode:mainfrom
Nacho1499:fix/Error-boundary

Conversation

@Nacho1499

Copy link
Copy Markdown
Contributor

Closes #708

PR Description:
This PR addresses the security vulnerability where was hardcoding . This caused full stack traces and internal implementation details to be exposed to end-users in production environments.ErrorBoundarySystemshowDetails={true}

Changes:

  1. Updated to include an optional prop, defaulting to .ErrorBoundarySystem.tsxshowDetailsprocess.env.NODE_ENV === 'development'

  2. Applied environment-based security guards to and .src/app/error.tsxsrc/app/global-error.tsx

  3. Ensured includes mandatory and tags for Next.js consistency.global-error.tsx

Type of Change
[x] Bug fix

Checklist:
[x] Code follows project style guidelines
[x] Self-review completed
[x] No console errors
[x] Uses Lucide icons consistently
[x] Responsive design implemented
[x] Starknet best practices followed

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Great job so far

There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass?

Happy to review again once that’s done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Error boundary showDetails is hardcoded to true, exposing stack traces in production

2 participants