fix(#726): Validate API version string format in middleware#843
Open
KingDavid9999 wants to merge 10 commits into
Open
fix(#726): Validate API version string format in middleware#843KingDavid9999 wants to merge 10 commits into
KingDavid9999 wants to merge 10 commits into
Conversation
- Add twitter and openGraph fields to root layout metadata (global default) - Create (auth)/layout.tsx with Twitter Cards for login, signup, verify-email - Extend metadata in editor, search, study-groups, leaderboard, privacy pages - Add Twitter Cards to generateMetadata in topics/[slug] and courses/[courseId] - Add unit tests to verify twitter card fields across layout files Closes rinafcode#378
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #726
The middleware was extracting the API version from the URL path without validating its format, allowing malformed or path-traversal strings to bypass version-based routing logic.
Changes
src/middleware.tsAdded regex validation (/^v\d+$/) on the extracted version segment before use. Malformed version strings now return a400 Bad Requestresponse.src/middleware/__tests__/apiVersioning.test.tsAdded tests covering valid versions (v1,v2,v10) and malformed inputs (vABC,../v1,v/,v1.2,v1;drop,123).docs/API_VERSIONING_POLICY.mdDocumented supported version format, active/planned versions, and rejection examples.Acceptance Criteria
400v1,v2) route correctly and setX-Api-Versionheader