Skip to content

update ratelimter file#842

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Dev-Zully:Rate-Limiter
Jun 29, 2026
Merged

update ratelimter file#842
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
Dev-Zully:Rate-Limiter

Conversation

@Dev-Zully

Copy link
Copy Markdown

[Performance] Rate limiter cleanup is an O(n) linear scan fired every 60 seconds
Overview
src/lib/ratelimit.ts runs a setInterval every 60 seconds that iterates over the entire in-memory store to find and delete expired entries. Under high traffic the store can accumulate thousands of IP entries; an O(n) scan on every cleanup tick adds unnecessary latency to any request handled concurrently on the same event loop turn.

Specifications
Features:

Expired rate-limit entries are removed efficiently without scanning the entire store
Cleanup does not block request handling
Tasks:

Replace the flat Map with a min-heap or sorted structure ordered by expiry time
Alternatively, use lazy eviction: check and remove an entry at the moment it is accessed and found expired
If using Redis for distributed rate limiting, TTL-based expiry handles this natively
Impacted Files:

src/lib/ratelimit.ts
Acceptance Criteria
Cleanup time does not grow linearly with the number of tracked IPs
Expired entries are evicted before the next request from that IP is processed
Rate limiter tests still pass
closes #735

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@Dev-Zully Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit 02548c6 into rinafcode:main Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Performance] Rate limiter cleanup is an O(n) linear scan fired every 60 seconds

2 participants