update ratelimter file#842
Merged
Merged
Conversation
|
@Dev-Zully Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Performance] Rate limiter cleanup is an O(n) linear scan fired every 60 seconds
Overview
src/lib/ratelimit.ts runs a setInterval every 60 seconds that iterates over the entire in-memory store to find and delete expired entries. Under high traffic the store can accumulate thousands of IP entries; an O(n) scan on every cleanup tick adds unnecessary latency to any request handled concurrently on the same event loop turn.
Specifications
Features:
Expired rate-limit entries are removed efficiently without scanning the entire store
Cleanup does not block request handling
Tasks:
Replace the flat Map with a min-heap or sorted structure ordered by expiry time
Alternatively, use lazy eviction: check and remove an entry at the moment it is accessed and found expired
If using Redis for distributed rate limiting, TTL-based expiry handles this natively
Impacted Files:
src/lib/ratelimit.ts
Acceptance Criteria
Cleanup time does not grow linearly with the number of tracked IPs
Expired entries are evicted before the next request from that IP is processed
Rate limiter tests still pass
closes #735