fix: add fake-timer tests for useQuiz timer auto-submit - #1320
Merged
Conversation
…timer auto-submit on expiry
|
@payfoxX Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #947
I implemented fake-timer tests for the useQuiz hook to verify the timer auto-submit functionality on expiry.
What I fixed
I added comprehensive tests that ensure the timer correctly auto-submits when it expires, that the timer clears upon completion, and that it does not run in review mode. These tests use vitest's fake timers to simulate time progression and assert the expected behavior based on the hook's API.
Issue before the fix
Before the change, the useQuiz hook's timer functionality was not tested. Specifically, there was no verification that complete() is called and isCompleted becomes true when the timer expires, that the interval is cleared on completion, or that the timer remains inactive in review mode. This lack of tests could lead to undetected bugs in the quiz completion logic, potentially causing issues such as quizzes not submitting automatically or timers running inappropriately.
Files changed