Skip to content

feat: add Redis-backed exchange rate caching with stale-while-revalidate#932

Open
sudo-robi wants to merge 2 commits into
rinafcode:mainfrom
sudo-robi:feat/exchange-rate-caching
Open

feat: add Redis-backed exchange rate caching with stale-while-revalidate#932
sudo-robi wants to merge 2 commits into
rinafcode:mainfrom
sudo-robi:feat/exchange-rate-caching

Conversation

@sudo-robi

Copy link
Copy Markdown
Contributor

closes #838

Replace in-memory exchange rate cache with CachingService-backed Redis cache.
- Primary cache key exchange-rate:{from}:{to} with 1-hour TTL via getOrSet
- Stale fallback key with 2-hour TTL for stale-while-revalidate
- Async background refresh when serving stale rates
- Graceful fallback to hardcoded rates on total cache miss + API failure
- Remove OnModuleInit and in-memory refresh logic
@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@sudo-robi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add caching layer for exchange rate lookups in PricingService

1 participant