Skip to content

feat: add known Metro Symbols - #31

Draft
rhwood wants to merge 3 commits into
mainfrom
metro-symbols
Draft

feat: add known Metro Symbols#31
rhwood wants to merge 3 commits into
mainfrom
metro-symbols

Conversation

@rhwood

@rhwood rhwood commented Jan 9, 2022

Copy link
Copy Markdown
Owner

These symbols should be easily used with Image(metroName: "name") in the same manner as Image(systemName: "name") provides access to system symbols.

Fixes #28

@rhwood rhwood self-assigned this Jan 9, 2022
@rhwood
rhwood marked this pull request as draft January 9, 2022 14:26
@rhwood

rhwood commented Jan 9, 2022

Copy link
Copy Markdown
Owner Author

This is draft as the SVGs in this library are not rescaling the way SVGs provided by Apple do.

@sonarqubecloud

sonarqubecloud Bot commented Jan 9, 2022

Copy link
Copy Markdown

Please retry analysis of this Pull-Request directly on SonarCloud.

These symbols should be easily used with `Image(metroName: "name")` in the same manner as `Image(systemName: "name")` provides access to system symbols.
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter

codecov-commenter commented Feb 24, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.37%. Comparing base (a3506d4) to head (5734c56).
⚠️ Report is 242 commits behind head on main.

Files with missing lines Patch % Lines
Sources/WMATAUI/WMATAUI.swift 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   61.74%   64.37%   +2.63%     
==========================================
  Files           4        5       +1     
  Lines         149      160      +11     
==========================================
+ Hits           92      103      +11     
  Misses         57       57              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icons

2 participants