python workflow - #755
Conversation
|
@masayag i need your review here. @gabriel-farache is on PTO |
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
Looks good. maybe you could add another step to the workflow, at is a bit stubbed (one step workflow). maybe one step for python import scripts and another for the external script call.
| def calculate_sum(numbers): | ||
| """Calculate sum of numbers""" | ||
| return sum(numbers) |
There was a problem hiding this comment.
no. but this is an example for a real script with multiple functions. do u think i should remove the unused function?
There was a problem hiding this comment.
I don't see the use to it, you just want to show that an external script has multiple functions and some are used and some are not?
FLPATH-2550 FLPATH-2551 https://issues.redhat.com/browse/FLPATH-2550 https://issues.redhat.com/browse/FLPATH-2551 Signed-off-by: Yaron Dayagi <[email protected]>
I prefer to have one state. this makes the example more advanced and complex and user can understand the capabilities. |
3 participants
FLPATH-2550
FLPATH-2551
https://issues.redhat.com/browse/FLPATH-2550
https://issues.redhat.com/browse/FLPATH-2551