multiple clusters in patch-k8s-resource - #695
Merged
Merged
Conversation
ydayagi
marked this pull request as draft
June 19, 2025 15:42
ydayagi
marked this pull request as ready for review
September 21, 2025 09:29
ydayagi
requested review from
elai-shalev,
gabriel-farache,
gciavarrini and
pkliczewski
September 21, 2025 09:33
| - name: patch | ||
| operation: "specs/patch-k8s-resource.yaml#patchResource" | ||
| metadata: | ||
| configKey: ".clusterName" |
Collaborator
There was a problem hiding this comment.
so the configKey metadata will be used to map the openapi spec URL to the right cluster, it's using the following pattern: quarkus.rest-client."<normalised_spec_file>.<configKey>".url am I right?
Is this documented anywhere in sonataflow/openapi generator docs?
Contributor
There was a problem hiding this comment.
I think we need to document so users know how to provide it
gabriel-farache
approved these changes
Sep 22, 2025
gabriel-farache
left a comment
gabriel-farache
left a comment
Collaborator
There was a problem hiding this comment.
nice, just a typo and a question about doc with configKey metdata mapping the cluster URL
FLPATH-2424 https://issues.redhat.com/browse/FLPATH-2424 Signed-off-by: Yaron Dayagi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLPATH-2424
https://issues.redhat.com/browse/FLPATH-2424