Skip to content

Refactor response validation#1264

Merged
JackWilb merged 4 commits into
devfrom
codex/response-validation-cleanup
Jul 17, 2026
Merged

Refactor response validation#1264
JackWilb merged 4 commits into
devfrom
codex/response-validation-cleanup

Conversation

@JackWilb

@JackWilb JackWilb commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a pure validateResponse API as the single source of truth for response validity
  • make Mantine form validation and response issue summaries delegate to the pure validator
  • extract response-value aggregation helpers in ResponseBlock
  • add focused unit coverage for current validation behavior and ResponseBlock feedback/error guards

Verification

  • yarn unittest --run src/components/response/tests/utils.spec.ts src/components/response/tests/ResponseBlock.spec.tsx
  • yarn typecheck
  • yarn lint
  • git diff --check

@github-actions

github-actions Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

🪓 PR closed, deleted preview.

jaykim1213
jaykim1213 requested changes Jun 23, 2026
View reviewed changes
Comment thread .github/workflows/lint_build.yaml
Comment thread .github/workflows/lint_build.yaml
Comment thread src/components/response/utils.ts
Comment thread src/components/response/responseErrors.ts Outdated
@JackWilb
JackWilb requested a review from jaykim1213 June 24, 2026 04:13
@JackWilb
JackWilb enabled auto-merge July 13, 2026 05:50
@JackWilb
JackWilb force-pushed the codex/response-validation-cleanup branch from 7efe323 to 6459c9d Compare July 14, 2026 23:51
@jaykim1213 jaykim1213 mentioned this pull request Jul 17, 2026
Open
38 tasks
@JackWilb
JackWilb force-pushed the codex/response-validation-cleanup branch from 6459c9d to fd34382 Compare July 17, 2026 17:23
@JackWilb
JackWilb force-pushed the codex/response-validation-cleanup branch from fd34382 to f3fbfe0 Compare July 17, 2026 19:46
@JackWilb
JackWilb disabled auto-merge July 17, 2026 19:54
@JackWilb
JackWilb merged commit 5a30511 into dev Jul 17, 2026
7 checks passed
@JackWilb
JackWilb deleted the codex/response-validation-cleanup branch July 17, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaykim1213 jaykim1213 jaykim1213 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JackWilb @jaykim1213