fix: harden workflow editor protocol prompts

[Nek-12]

Summary

• harden workflow editor protocol prompt handling and graph layout behavior
• inline project-authored trivial Go wrappers/helpers while preserving behavior
• centralize CLI/server architecture-test exceptions with exact rationale-backed allowlist entries

Verification

• go test ./...
• ./scripts/test.sh
• ./scripts/build.sh --output ./bin/builder
• focused architecture/code-review checks for shared/architecture/boundary_test.go

[coderabbitai]

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a56452c6-49e0-4052-81fb-fa34db191666

📥 Commits

Reviewing files that changed from the base of the PR and between 91bb457 and 2e6245e.

📒 Files selected for processing (300)

• apps/desktop/src/api/client.test.ts
• apps/desktop/src/api/client.ts
• apps/desktop/src/api/errors.ts
• apps/desktop/src/api/jsonRpc.test.ts
• apps/desktop/src/api/jsonRpc.ts
• apps/desktop/src/api/jsonRpcSocket.ts
• apps/desktop/src/api/models.ts
• apps/desktop/src/api/schemas/workflow.ts
• apps/desktop/src/dev-showcase/DevShowcase.test.tsx
• apps/desktop/src/dev-showcase/DevShowcase.tsx
• apps/desktop/src/features/startup/StartupGate.test.tsx
• apps/desktop/src/features/startup/StartupGate.tsx
• apps/desktop/src/features/startup/useStartup.ts
• apps/desktop/src/features/workflow-editor/WorkflowEditorRoute.test.tsx
• apps/desktop/src/features/workflow-editor/WorkflowEditorRoute.tsx
• apps/desktop/src/features/workflow-editor/WorkflowGraphCanvas.test.tsx
• apps/desktop/src/features/workflow-editor/WorkflowGraphEdge.test.tsx
• apps/desktop/src/features/workflow-editor/WorkflowGraphNodes.tsx
• apps/desktop/src/features/workflow-editor/WorkflowInspectorSidebar.tsx
• apps/desktop/src/features/workflow-editor/workflow-editor.css
• apps/desktop/src/features/workflow-editor/workflowDeleteConfirmationPolicy.test.ts
• apps/desktop/src/features/workflow-editor/workflowEditorDraft.test.ts
• apps/desktop/src/features/workflow-editor/workflowEditorDraft.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphEdgeMutations.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphMutationFixtures.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphMutationHelpers.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphMutationTypes.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphMutations.test.ts
• apps/desktop/src/features/workflow-editor/workflowEditorGraphNodeMutations.ts
• apps/desktop/src/features/workflow-editor/workflowGraphEdges.ts
• apps/desktop/src/features/workflow-editor/workflowGraphLayout.test.ts
• apps/desktop/src/features/workflow-editor/workflowGraphLayout.ts
• apps/desktop/src/features/workflow-editor/workflowGraphLayoutEdgeRoutes.ts
• apps/desktop/src/features/workflow-editor/workflowGraphLayoutGeometry.ts
• apps/desktop/src/features/workflow-editor/workflowGraphLayoutGroups.test.ts
• apps/desktop/src/features/workflow-editor/workflowInspectorModel.ts
• apps/desktop/src/i18n/workflowEditorEn.ts
• cli/app/app.go
• cli/app/auth_callback_page.go
• cli/app/auth_callback_page_test.go
• cli/app/auth_gate.go
• cli/app/auth_gate_test.go
• cli/app/auth_oauth_presenter.go
• cli/app/auth_oauth_presenter_test.go
• cli/app/auth_picker.go
• cli/app/auth_picker_test.go
• cli/app/bootstrap.go
• cli/app/bootstrap_test.go
• cli/app/embedded_server.go
• cli/app/embedded_server_part2_test.go
• cli/app/embedded_server_test.go
• cli/app/headless_prompt_server_test.go
• cli/app/internal/authflowadapter/flow.go
• cli/app/internal/authflowadapter/flow_test.go
• cli/app/internal/authoauth/runner.go
• cli/app/internal/embeddedstartup/start.go
• cli/app/internal/embeddedstartup/start_test.go
• cli/app/internal/oauthadapter/oauth.go
• cli/app/internal/oauthadapter/oauth_test.go
• cli/app/internal/onboardingimport/skill_metadata.go
• cli/app/internal/onboardingmodel/model.go
• cli/app/internal/onboardingmodel/model_test.go
• cli/app/internal/onboardingready/ready.go
• cli/app/internal/onboardingready/ready_test.go
• cli/app/internal/projectpicker/picker.go
• cli/app/internal/projectpicker/picker_test.go
• cli/app/internal/runtimeattach/lease.go
• cli/app/internal/servecommand/servecommand.go
• cli/app/internal/serverattach/attach_test.go
• cli/app/internal/serverbridge/contracts_test.go
• cli/app/internal/serverbridge/serverbridge.go
• cli/app/internal/startupconfig/config.go
• cli/app/internal/statuscollect/collect.go
• cli/app/internal/statuscollect/environment.go
• cli/app/internal/statuscollect/model.go
• cli/app/internal/worktreemutation/service.go
• cli/app/internal/worktreemutation/service_test.go
• cli/app/launch_planner.go
• cli/app/manual_alt_screen_input_repro_test.go
• cli/app/onboarding_flow.go
• cli/app/onboarding_imports.go
• cli/app/onboarding_model.go
• cli/app/onboarding_part2_test.go
• cli/app/onboarding_render.go
• cli/app/onboarding_run.go
• cli/app/onboarding_test.go
• cli/app/onboarding_workflow.go
• cli/app/patch_outside_workspace_approver_test.go
• cli/app/project_binding_flow.go
• cli/app/project_binding_flow_test.go
• cli/app/project_name_prompt.go
• cli/app/prompt_events.go
• cli/app/remote_auth_bootstrap.go
• cli/app/remote_auth_bootstrap_test.go
• cli/app/remote_server.go
• cli/app/remote_server_test.go
• cli/app/run_prompt.go
• cli/app/run_prompt_part2_test.go
• cli/app/run_prompt_target.go
• cli/app/run_prompt_test.go
• cli/app/runtime_attachment.go
• cli/app/runtime_event_bridge_test.go
• cli/app/runtime_event_bridge_test_helper_test.go
• cli/app/runtime_factory_test.go
• cli/app/runtime_projection_test.go
• cli/app/session_lifecycle.go
• cli/app/session_lifecycle_part2_test.go
• cli/app/session_lifecycle_test.go
• cli/app/session_picker.go
• cli/app/session_picker_status.go
• cli/app/session_picker_test.go
• cli/app/session_server_target.go
• cli/app/session_server_target_part2_test.go
• cli/app/session_server_target_part3_test.go
• cli/app/session_server_target_test.go
• cli/app/stream_resubscribe_test.go
• cli/app/terminal_bell.go
• cli/app/ui.go
• cli/app/ui_alt_screen.go
• cli/app/ui_alt_screen_test.go
• cli/app/ui_ask_controller.go
• cli/app/ui_ask_deferred_test.go
• cli/app/ui_background_notifications_test.go
• cli/app/ui_busy_commands_test.go
• cli/app/ui_clipboard.go
• cli/app/ui_clipboard_test.go
• cli/app/ui_committed_suffix_delivery.go
• cli/app/ui_compaction_resume_test.go
• cli/app/ui_diff_render_test.go
• cli/app/ui_event_reducers.go
• cli/app/ui_feature_reducers.go
• cli/app/ui_goal.go
• cli/app/ui_goal_test.go
• cli/app/ui_help.go
• cli/app/ui_input_buffer.go
• cli/app/ui_input_controller.go
• cli/app/ui_input_controller_commands.go
• cli/app/ui_input_controller_flows.go
• cli/app/ui_input_controller_keys.go
• cli/app/ui_input_controller_status.go
• cli/app/ui_input_edit_keys.go
• cli/app/ui_input_mode.go
• cli/app/ui_input_queue.go
• cli/app/ui_input_resume.go
• cli/app/ui_input_slash_commands.go
• cli/app/ui_input_submission.go
• cli/app/ui_key_adapter.go
• cli/app/ui_key_reducer.go
• cli/app/ui_layout.go
• cli/app/ui_layout_rendering_helpers.go
• cli/app/ui_layout_rendering_input.go
• cli/app/ui_layout_rendering_status.go
• cli/app/ui_layout_rendering_status_overlay.go
• cli/app/ui_layout_rendering_viewport.go
• cli/app/ui_layout_seams_test.go
• cli/app/ui_loop.go
• cli/app/ui_main_thread_strict_test.go
• cli/app/ui_mode_flow_test.go
• cli/app/ui_mode_transition_output_test.go
• cli/app/ui_model_defaults.go
• cli/app/ui_native_history.go
• cli/app/ui_native_history_benchmark_test.go
• cli/app/ui_native_history_part2_test.go
• cli/app/ui_native_history_part3_test.go
• cli/app/ui_native_history_projection.go
• cli/app/ui_native_history_test.go
• cli/app/ui_native_scrollback_integration_part2_test.go
• cli/app/ui_native_scrollback_integration_part3_test.go
• cli/app/ui_native_scrollback_integration_part4_test.go
• cli/app/ui_native_scrollback_integration_part5_test.go
• cli/app/ui_native_scrollback_integration_test.go
• cli/app/ui_native_stream_controller.go
• cli/app/ui_part10_test.go
• cli/app/ui_part2_test.go
• cli/app/ui_part3_test.go
• cli/app/ui_part4_test.go
• cli/app/ui_part5_test.go
• cli/app/ui_part6_test.go
• cli/app/ui_part7_test.go
• cli/app/ui_part8_test.go
• cli/app/ui_part9_test.go
• cli/app/ui_path_reference_integration_test.go
• cli/app/ui_path_reference_picker.go
• cli/app/ui_path_reference_types.go
• cli/app/ui_pending_tools.go
• cli/app/ui_process_client.go
• cli/app/ui_process_render.go
• cli/app/ui_processes.go
• cli/app/ui_projected_runtime_part2_test.go
• cli/app/ui_projected_runtime_test.go
• cli/app/ui_prompt_history.go
• cli/app/ui_rollback.go
• cli/app/ui_runtime_adapter.go
• cli/app/ui_runtime_adapter_part2_test.go
• cli/app/ui_runtime_adapter_part3_test.go
• cli/app/ui_runtime_adapter_part4_test.go
• cli/app/ui_runtime_adapter_part5_test.go
• cli/app/ui_runtime_adapter_part6_test.go
• cli/app/ui_runtime_adapter_test.go
• cli/app/ui_runtime_client.go
• cli/app/ui_runtime_client_control.go
• cli/app/ui_runtime_client_part2_test.go
• cli/app/ui_runtime_client_test.go
• cli/app/ui_runtime_control.go
• cli/app/ui_runtime_control_test.go
• cli/app/ui_runtime_event_reduction.go
• cli/app/ui_runtime_reducer.go
• cli/app/ui_runtime_status.go
• cli/app/ui_runtime_status_test.go
• cli/app/ui_runtime_sync.go
• cli/app/ui_scroll_keys_test.go
• cli/app/ui_slash_command_picker.go
• cli/app/ui_slash_command_picker_test.go
• cli/app/ui_status.go
• cli/app/ui_status_overlay_format.go
• cli/app/ui_status_part2_test.go
• cli/app/ui_status_test.go
• cli/app/ui_terminal_cursor_test.go
• cli/app/ui_test.go
• cli/app/ui_text_editor.go
• cli/app/ui_transcript_diag_test.go
• cli/app/ui_transcript_entries.go
• cli/app/ui_transcript_event_apply.go
• cli/app/ui_transcript_event_reducer.go
• cli/app/ui_transcript_mode.go
• cli/app/ui_transcript_page_apply.go
• cli/app/ui_transcript_page_reducer.go
• cli/app/ui_transcript_pager.go
• cli/app/ui_transcript_runtime_state.go
• cli/app/ui_transcript_sync_policy_test.go
• cli/app/ui_transcript_sync_recovery_test.go
• cli/app/ui_window_reducer.go
• cli/app/ui_worktree_commands.go
• cli/app/ui_worktree_commands_part2_test.go
• cli/app/ui_worktree_commands_test.go
• cli/app/ui_worktree_create_controller.go
• cli/app/ui_worktree_create_controller_test.go
• cli/app/ui_worktree_delete_controller.go
• cli/app/ui_worktree_list_controller.go
• cli/app/ui_worktree_reducer.go
• cli/app/ui_worktree_render.go
• cli/app/ui_worktrees.go
• cli/app/workspace_change_prompt.go
• cli/app/workspace_registration_test.go
• cli/builder/binding_commands.go
• cli/builder/binding_commands_test.go
• cli/builder/command_flags.go
• cli/builder/goal_command.go
• cli/builder/goal_command_test.go
• cli/builder/help.go
• cli/builder/internal/serverbridge/serverbridge.go
• cli/builder/main.go
• cli/builder/serve.go
• cli/builder/service_command.go
• cli/builder/task_command.go
• cli/builder/workflow_command.go
• cli/tui/ansi_style_transform.go
• cli/tui/code_renderer.go
• cli/tui/detail_compact_test.go
• cli/tui/detail_rendering.go
• cli/tui/input/editor.go
• cli/tui/input/field.go
• cli/tui/input/field_test.go
• cli/tui/markdown_renderer.go
• cli/tui/model.go
• cli/tui/model_reducer.go
• cli/tui/model_rendering.go
• cli/tui/model_rendering_entries.go
• cli/tui/model_rendering_style.go
• cli/tui/model_rendering_tools.go
• cli/tui/pending_snapshot.go
• cli/tui/render_style_intents.go
• cli/tui/renderer_style_adapter.go
• cli/tui/roles.go
• cli/tui/transcript_intents.go
• cli/tui/transcript_projection.go
• cli/tui/transcript_projection_test.go
• docs/dev/specs/workflow-editor.md
• prompts/embed.go
• prompts/embed_test.go
• prompts/generated_skills_test.go
• prompts/goal/agent_command_denied.md
• prompts/goal/agent_duplicate_set_denied.md
• prompts/goal/clear.md
• prompts/goal/complete_confirm_required.md
• prompts/goal/nudge.md
• prompts/goal/pause.md
• prompts/goal/set.md
• prompts/reviewer_system_prompt.md
• prompts/system_prompt/delegation.md
• scripts/export-reviewer-request.sh
• server/auth/openai_oauth_browser.go
• server/auth/openai_oauth_browser_test.go
• server/authpolicy/policy.go
• server/embedded/embedded.go
• server/embedded/embedded_test.go
• server/launch/subagents.go
• server/launch/test_helpers_test.go
• server/llm/capability_registry.go
• server/llm/openai_http.go

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/workflow-editor-protocol-prompts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}