Fix prefix matching in process_repomd NVRA alias lookup#81
Merged
brianclemens merged 1 commit intoMay 21, 2026
Merged
Conversation
4dee213 to
485b99c
Compare
…eaned-keyed dict The pkg_name_map (formerly raw_package_map) stored raw NVRAs but was used to create aliases looked up in raw_pkg_nvras, which is keyed by cleaned NVRAs. For packages with Rocky-specific release suffixes (e.g. .rocky.0.1), the raw value includes the dist tag (.el9_7) while the cleaned key does not, so the lookup always failed silently. This broke advisory cloning for any package where the Rocky release string differs from the Red Hat original, such as openssh. The equivalent map in clone_advisory (pkg_name_map) already stores cleaned NVRAs correctly. Also deduplicates cleaned NVRAs in pkg_name_map to avoid redundant prefix matching iterations from module stream rebuilds.
485b99c to
655f36a
Compare
brianclemens
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_repomd()prefix matching stored raw NVRAs in its package name map but used them to look up packages in a cleaned-NVRA-keyed dict, so the lookup always failed silently for packages with Rocky-specific release suffixes (e.g..rocky.0.1)raw_package_maptopkg_name_mapand changed it to store cleaned NVRAs, matching the pattern already used correctly inclone_advisory()Closes #80
Test plan