Fixes for Python 3.12 datetime behaviour#24
Open
nathanjrobertson wants to merge 1 commit into
Open
Conversation
Author
|
@GRysev-UKKA Would you be able to take a look at this PR? Without it PyXB-X doesn't pass tests on Python 3.12. |
GlebRysev-UKKA
approved these changes
Jul 22, 2026
GlebRysev-UKKA
left a comment
GlebRysev-UKKA
left a comment
There was a problem hiding this comment.
Tested locally on 3.8 and 3.12, all works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes fixes for the two pytest failures when running against Python 3.12, due to a change in Python 3.12 regarding how datetime.replace() behaves with subclasses.
I've tested the pytest tests with Python 3.10, 3.11, 3.12, 3.13 and 3.14 (being all of the currently supported versions). All tests now pass on all of those versions.