Enable pre_onboarding_requirements feature flag in example app#1153
Open
cammellos wants to merge 1 commit into
Open
Enable pre_onboarding_requirements feature flag in example app#1153cammellos wants to merge 1 commit into
cammellos wants to merge 1 commit into
Conversation
Turns on the pre_onboarding_requirements feature in the Onboarding example so the already-built PreOnboardingRequirements component (used in ReviewOnboardingStep) actually receives data to render.
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreOnboardingRequirementscomponent is already built and wired intoOnboardingFlow/ReviewOnboardingStep, but its data fetch is gated behind thepre_onboarding_requirementsfeature flag, which the example app didn't enable — so it silently rendered nothing.'pre_onboarding_requirements'to thefeaturesarray inexample/src/Onboarding.tsxso the example actually demonstrates the pre-onboarding requirements flow (e.g. Acknowledgement / CSW-style requirements for EOR hires).Test plan