fix: select standard plan so contract_origin step is visible in jsfMo…#1150
Merged
Conversation
…dify test
The contract_origin step only renders when the selected pricing plan is the
standard product ('Contractor Management'). The test defaulted to
'Contractor Management Plus', hiding the step and causing a timeout after
merging PRs #1147 and #1148.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (345 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
The includeContractOrigin effect reacts to the selected plan asynchronously; on slow CI the Next click fired before it settled, skipping the contract_origin step. Wait for the standard-plan radio to be checked before navigating. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
The radio-checked wait resolved before the includeContractOrigin effect propagated to the steps array, so on slow CI the Next click still skipped the step. Expose visible steps from the bag in the test mock and wait until contract_origin is present, which is deterministic regardless of CI speed. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
remotecom
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dify test
The contract_origin step only renders when the selected pricing plan is the standard product ('Contractor Management'). The test defaulted to 'Contractor Management Plus', hiding the step and causing a timeout after merging PRs #1147 and #1148.
Note
Low Risk
Test-only changes with no production code paths affected.
Overview
Fixes a flaky Contractor Onboarding integration test that exercises
jsfModifyon the Contract Origin step.The test now selects Contractor Management (standard plan) instead of relying on the helper default Contractor Management Plus, because
contract_originis only in the visible step list for the standard product. It also asserts via a newvisible-stepstest hook thatcontract_originis present before advancing, and the shared test renderer exposes visible step names for that check.Reviewed by Cursor Bugbot for commit 3e5709d. Bugbot is set up for automated code reviews on this repo. Configure here.